From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8DFC2D0A3 for ; Mon, 9 Nov 2020 10:46:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A535C206E3 for ; Mon, 9 Nov 2020 10:46:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iuwckP3J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A535C206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc4gV-0004IN-Du for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 05:46:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc4fm-0003gt-DV for qemu-devel@nongnu.org; Mon, 09 Nov 2020 05:45:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc4fk-00079t-KQ for qemu-devel@nongnu.org; Mon, 09 Nov 2020 05:45:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604918715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IvovXvGi96RLS5Xlxa3vEz79xbJKjbaUI17fwHflXc8=; b=iuwckP3J92O8ZdmR+tMVXKRVuRZHLaKkhLfZOAvXLG4g+4fbcJbrMGCQoqoYD4C9/H61bz ni3WP/OY9GXRquyYRe7DAFMUaKB+LlCQL8PsEuki6F/PWAXTppTQ0kVj0MT6fvoFHAF2aH KZeOV4cIDREHdf9JDggUKJbgUeLZmtM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-bZouaZUZO4upuVnTmkfAdA-1; Mon, 09 Nov 2020 05:45:13 -0500 X-MC-Unique: bZouaZUZO4upuVnTmkfAdA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B25E2186840C; Mon, 9 Nov 2020 10:45:11 +0000 (UTC) Received: from gondolin (ovpn-113-28.ams2.redhat.com [10.36.113.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id D14D075125; Mon, 9 Nov 2020 10:44:57 +0000 (UTC) Date: Mon, 9 Nov 2020 11:44:55 +0100 From: Cornelia Huck To: Eduardo Habkost Subject: Re: [PATCH 4/7] qom: Replace void* parameter with Property* on field getters/setters Message-ID: <20201109114455.2eb0fabd.cohuck@redhat.com> In-Reply-To: <20201104172512.2381656-5-ehabkost@redhat.com> References: <20201104172512.2381656-1-ehabkost@redhat.com> <20201104172512.2381656-5-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , Paul Durrant , Mark Cave-Ayland , qemu-devel@nongnu.org, Stefano Stabellini , qemu-block@nongnu.org, Stefan Berger , David Hildenbrand , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Thomas Huth , qemu-s390x@nongnu.org, Igor Mammedov , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Alex Williamson , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 4 Nov 2020 12:25:09 -0500 Eduardo Habkost wrote: > All field property getters and setters must interpret the fourth > argument as Property*. Change the function signature of field > property getters and setters to indicate that. >=20 > Signed-off-by: Eduardo Habkost > --- > Cc: Stefan Berger > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Cc: Kevin Wolf > Cc: Max Reitz > Cc: Paolo Bonzini > Cc: "Daniel P. Berrang=C3=A9" > Cc: Eduardo Habkost > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Matthew Rosato > Cc: Alex Williamson > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Cc: qemu-devel@nongnu.org > Cc: xen-devel@lists.xenproject.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > --- > include/qom/field-property-internal.h | 8 +- > include/qom/field-property.h | 26 ++++--- > backends/tpm/tpm_util.c | 11 ++- > hw/block/xen-block.c | 6 +- > hw/core/qdev-properties-system.c | 86 +++++++++------------- > hw/s390x/css.c | 6 +- > hw/s390x/s390-pci-bus.c | 6 +- > hw/vfio/pci-quirks.c | 10 +-- > qom/property-types.c | 102 +++++++++----------------- > target/sparc/cpu.c | 4 +- > 10 files changed, 105 insertions(+), 160 deletions(-) Acked-by: Cornelia Huck