qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	"Venegas Munoz,
	Jose Carlos" <jose.carlos.venegas.munoz@intel.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	virtio-fs-list <virtio-fs@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Shinde, Archana M" <archana.m.shinde@intel.com>
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool
Date: Mon, 9 Nov 2020 09:39:42 -0500	[thread overview]
Message-ID: <20201109143942.GB1479853@redhat.com> (raw)
In-Reply-To: <20201109100218.GD3024@work-vm>

On Mon, Nov 09, 2020 at 10:02:18AM +0000, Dr. David Alan Gilbert wrote:

[..]
> > Given in my tests, most of the workload benefited from
> > --thread-pool-size=0, may be this can be the default and user can
> > opt-in for a thread pool (--thread-pool-size=64) once it is known
> > that a particular workload benefits from it.
> > 
> > David, Stefan, WDYT?
> 
> I think having the option makes sense; the default I'm not sure about;

Ok, for now we can probably just introduce this option. And if further
test results prove it to be faster for most of the people, then we
can consider switching the default.

Vivek



  reply	other threads:[~2020-11-09 14:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 19:44 [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool Vivek Goyal
2020-11-05 19:52 ` [Virtio-fs] " Vivek Goyal
2020-11-06 20:33   ` Venegas Munoz, Jose Carlos
2020-11-06 22:35     ` Vivek Goyal
2020-11-09 10:02       ` Dr. David Alan Gilbert
2020-11-09 14:39         ` Vivek Goyal [this message]
2020-11-12  9:06       ` Miklos Szeredi
2020-11-12  9:57         ` Miklos Szeredi
2020-11-18 20:19           ` Vivek Goyal
2020-11-12 11:00         ` Christian Schoenebeck
2020-11-12 13:01           ` Miklos Szeredi
2020-11-17 16:00         ` Venegas Munoz, Jose Carlos
2020-11-17 16:39           ` Christian Schoenebeck
2020-11-17 18:55           ` Vivek Goyal
2020-11-23 15:06             ` Venegas Munoz, Jose Carlos
2020-11-17 22:24           ` Vivek Goyal
2020-11-23 15:07             ` Venegas Munoz, Jose Carlos
2020-11-18 19:51         ` Vivek Goyal
2020-11-23  9:46           ` Miklos Szeredi
2020-11-09 10:11 ` Dr. David Alan Gilbert
2020-11-09 14:40   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109143942.GB1479853@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=archana.m.shinde@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=jose.carlos.venegas.munoz@intel.com \
    --cc=miklos@szeredi.hu \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).