From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4B0C2D0A3 for ; Mon, 9 Nov 2020 14:42:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D05020853 for ; Mon, 9 Nov 2020 14:42:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JNUV1uX9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D05020853 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc8N1-00036D-0P for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 09:42:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc8Kr-000201-Po for qemu-devel@nongnu.org; Mon, 09 Nov 2020 09:39:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc8Kq-0004Co-5M for qemu-devel@nongnu.org; Mon, 09 Nov 2020 09:39:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604932795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/EdfleJG8f8h/BjAasa7oBJCA9NJEAGjzaYIj35lWXc=; b=JNUV1uX9aFaSkO5DEtB+NOs5WSzlrzZCCacPka+Yzr8wxMAjw0hYC5I4UKO4m8cm7FWsHg qu+O6ZKTuCeUMZsnHcuhbAJSugyj4pdZCFi9spevvJ/M48JcLqlxCwXCjPB+BGkX2Piic4 gg5ysTKYhabRFyuznnHaI7o+suIkHus= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-Nwhx8nrNMsSRtykI1pxVdg-1; Mon, 09 Nov 2020 09:39:53 -0500 X-MC-Unique: Nwhx8nrNMsSRtykI1pxVdg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3FC691891E93; Mon, 9 Nov 2020 14:39:52 +0000 (UTC) Received: from horse.redhat.com (ovpn-115-201.rdu2.redhat.com [10.10.115.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id C78855B4CD; Mon, 9 Nov 2020 14:39:42 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 3052B222E35; Mon, 9 Nov 2020 09:39:42 -0500 (EST) Date: Mon, 9 Nov 2020 09:39:42 -0500 From: Vivek Goyal To: "Dr. David Alan Gilbert" Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool Message-ID: <20201109143942.GB1479853@redhat.com> References: <20201105194416.GA1384085@redhat.com> <20201105195253.GB1384085@redhat.com> <20201106223524.GG1436035@redhat.com> <20201109100218.GD3024@work-vm> MIME-Version: 1.0 In-Reply-To: <20201109100218.GD3024@work-vm> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 00:04:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miklos Szeredi , "Venegas Munoz, Jose Carlos" , "qemu-devel@nongnu.org" , virtio-fs-list , Stefan Hajnoczi , "Shinde, Archana M" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 09, 2020 at 10:02:18AM +0000, Dr. David Alan Gilbert wrote: [..] > > Given in my tests, most of the workload benefited from > > --thread-pool-size=0, may be this can be the default and user can > > opt-in for a thread pool (--thread-pool-size=64) once it is known > > that a particular workload benefits from it. > > > > David, Stefan, WDYT? > > I think having the option makes sense; the default I'm not sure about; Ok, for now we can probably just introduce this option. And if further test results prove it to be faster for most of the people, then we can consider switching the default. Vivek