* [NOTFORMERGE PATCH 0/2] scripts/checkpatch: Test if >100 chars per line is easy to review
@ 2020-11-09 16:19 Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 1/2] hw/net: Test line with 342 chars Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 2/2] hw/pci: Test line with 391 chars Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-09 16:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Philippe Mathieu-Daudé
Test if this changes are allowed by checkpatch.
Patchew should reply with a simple warning.
Based-on: <20201105154208.12442-1-ganqixin@huawei.com>
https://www.mail-archive.com/qemu-devel@nongnu.org/msg758018.html
Philippe Mathieu-Daudé (2):
hw/net: Test line with 342 chars
hw/pci: Test line with 391 chars
include/hw/net/imx_fec.h | 8 +-------
include/hw/pci/pcie_regs.h | 17 +----------------
2 files changed, 2 insertions(+), 23 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [NOTFORMERGE PATCH 1/2] hw/net: Test line with 342 chars
2020-11-09 16:19 [NOTFORMERGE PATCH 0/2] scripts/checkpatch: Test if >100 chars per line is easy to review Philippe Mathieu-Daudé
@ 2020-11-09 16:19 ` Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 2/2] hw/pci: Test line with 391 chars Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-09 16:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Philippe Mathieu-Daudé
Applying using unrestricted checkpatch:
WARNING: line over 100 characters
#16: FILE: include/hw/net/imx_fec.h:118:
This change is not easy to review in gitk.
$ xwininfo -root | egrep "Width|Height"
Width: 1920
Height: 2160
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/net/imx_fec.h | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/hw/net/imx_fec.h b/include/hw/net/imx_fec.h
index e3a8755db92..c3ac7d25823 100644
--- a/include/hw/net/imx_fec.h
+++ b/include/hw/net/imx_fec.h
@@ -115,13 +115,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(IMXFECState, IMX_FEC)
#define ENET_INT_TXF1 (1 << 3)
#define ENET_INT_TXB1 (1 << 2)
-#define ENET_INT_MAC (ENET_INT_HB | ENET_INT_BABR | ENET_INT_BABT | \
- ENET_INT_GRA | ENET_INT_TXF | ENET_INT_TXB | \
- ENET_INT_RXF | ENET_INT_RXB | ENET_INT_MII | \
- ENET_INT_EBERR | ENET_INT_LC | ENET_INT_RL | \
- ENET_INT_UN | ENET_INT_PLR | ENET_INT_WAKEUP | \
- ENET_INT_TS_AVAIL | ENET_INT_TXF1 | \
- ENET_INT_TXB1 | ENET_INT_TXF2 | ENET_INT_TXB2)
+#define ENET_INT_MAC (ENET_INT_HB | ENET_INT_BABR | ENET_INT_BABT | ENET_INT_GRA | ENET_INT_TXF | ENET_INT_TXB | ENET_INT_RXF | ENET_INT_RXB | ENET_INT_MII | ENET_INT_EBERR | ENET_INT_LC | ENET_INT_RL | ENET_INT_UN | ENET_INT_PLR | ENET_INT_WAKEUP | ENET_INT_TS_AVAIL | ENET_INT_TXF1 | ENET_INT_TXB1 | ENET_INT_TXF2 | ENET_INT_TXB2)
/* RDAR */
#define ENET_RDAR_RDAR (1 << 24)
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [NOTFORMERGE PATCH 2/2] hw/pci: Test line with 391 chars
2020-11-09 16:19 [NOTFORMERGE PATCH 0/2] scripts/checkpatch: Test if >100 chars per line is easy to review Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 1/2] hw/net: Test line with 342 chars Philippe Mathieu-Daudé
@ 2020-11-09 16:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-09 16:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Philippe Mathieu-Daudé
Applying using unrestricted checkpatch:
WARNING: line over 100 characters
#25: FILE: include/hw/pci/pcie_regs.h:141:
This change is not easy to review with 'git-log -p'.
$ echo ${COLUMNS}x${LINES}
210x52
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pcie_regs.h | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/include/hw/pci/pcie_regs.h b/include/hw/pci/pcie_regs.h
index 1db86b0ec4d..a2f02511986 100644
--- a/include/hw/pci/pcie_regs.h
+++ b/include/hw/pci/pcie_regs.h
@@ -138,22 +138,7 @@ typedef enum PCIExpLinkWidth {
PCI_ERR_ROOT_NONFATAL_RCV | \
PCI_ERR_ROOT_FATAL_RCV)
-#define PCI_ERR_UNC_SUPPORTED (PCI_ERR_UNC_DLP | \
- PCI_ERR_UNC_SDN | \
- PCI_ERR_UNC_POISON_TLP | \
- PCI_ERR_UNC_FCP | \
- PCI_ERR_UNC_COMP_TIME | \
- PCI_ERR_UNC_COMP_ABORT | \
- PCI_ERR_UNC_UNX_COMP | \
- PCI_ERR_UNC_RX_OVER | \
- PCI_ERR_UNC_MALF_TLP | \
- PCI_ERR_UNC_ECRC | \
- PCI_ERR_UNC_UNSUP | \
- PCI_ERR_UNC_ACSV | \
- PCI_ERR_UNC_INTN | \
- PCI_ERR_UNC_MCBTLP | \
- PCI_ERR_UNC_ATOP_EBLOCKED | \
- PCI_ERR_UNC_TLP_PRF_BLOCKED)
+#define PCI_ERR_UNC_SUPPORTED (PCI_ERR_UNC_DLP | PCI_ERR_UNC_SDN | PCI_ERR_UNC_POISON_TLP | PCI_ERR_UNC_FCP | PCI_ERR_UNC_COMP_TIME | PCI_ERR_UNC_COMP_ABORT | PCI_ERR_UNC_UNX_COMP | PCI_ERR_UNC_RX_OVER | PCI_ERR_UNC_MALF_TLP | PCI_ERR_UNC_ECRC | PCI_ERR_UNC_UNSUP | PCI_ERR_UNC_ACSV | PCI_ERR_UNC_INTN | PCI_ERR_UNC_MCBTLP | PCI_ERR_UNC_ATOP_EBLOCKED | PCI_ERR_UNC_TLP_PRF_BLOCKED)
#define PCI_ERR_UNC_SEVERITY_DEFAULT (PCI_ERR_UNC_DLP | \
PCI_ERR_UNC_SDN | \
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-09 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-09 16:19 [NOTFORMERGE PATCH 0/2] scripts/checkpatch: Test if >100 chars per line is easy to review Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 1/2] hw/net: Test line with 342 chars Philippe Mathieu-Daudé
2020-11-09 16:19 ` [NOTFORMERGE PATCH 2/2] hw/pci: Test line with 391 chars Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).