From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53594C2D0A3 for ; Mon, 9 Nov 2020 18:06:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A305A20663 for ; Mon, 9 Nov 2020 18:06:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BWa52fcD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A305A20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcBYX-00065W-Kt for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 13:06:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcBW0-0004Cr-TX for qemu-devel@nongnu.org; Mon, 09 Nov 2020 13:03:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcBVy-0000Jk-Tz for qemu-devel@nongnu.org; Mon, 09 Nov 2020 13:03:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604945018; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=uLpM+7k2lb5Y0VPCzeIrqiO0HSblSlNT3P0Gr6veMGs=; b=BWa52fcD6lmKdt+bKQLmgrFC0kQrNkpHspO09qUbabV98dNqcOQ8g48a/UVnrXSVm+Wdmn ZCOaxp/VBhMQZAJvLuP5rMZc0G4fkXOAH02jIDZ9qtsQegUYgPaKZJ4nkCh8CJ7guRZfxm EwQeCHNqulP4/OYYPR5qLdfsdFUA7Y4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-J5rObrr1PU-7lpZiggFXRg-1; Mon, 09 Nov 2020 13:03:21 -0500 X-MC-Unique: J5rObrr1PU-7lpZiggFXRg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6DABC803655; Mon, 9 Nov 2020 18:03:18 +0000 (UTC) Received: from redhat.com (ovpn-114-194.ams2.redhat.com [10.36.114.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AC1019C71; Mon, 9 Nov 2020 18:03:06 +0000 (UTC) Date: Mon, 9 Nov 2020 18:03:02 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Claudio Fontana Subject: Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration Message-ID: <20201109180302.GB814975@redhat.com> References: <20201109172755.16500-1-cfontana@suse.de> <20201109172755.16500-10-cfontana@suse.de> MIME-Version: 1.0 In-Reply-To: <20201109172755.16500-10-cfontana@suse.de> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Eduardo Habkost , Colin Xu , Paul Durrant , Jason Wang , Marcelo Tosatti , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , Roman Bolshakov , Cameron Esfahani , haxm-team@intel.com, Wenchao Wang , Anthony Perard , Paolo Bonzini , Sunil Muthuswamy , Bruce Rogers , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 09, 2020 at 06:27:54PM +0100, Claudio Fontana wrote: > split cpu.c into: > > cpu.c cpuid and common x86 cpu functionality > host-cpu.c host x86 cpu functions and "host" cpu type > kvm-cpu-type.c KVM x86 cpu type > hvf-cpu-type.c HVF x86 cpu type > tcg-cpu-type.c TCG x86 cpu type > > Defer the x86 models registration to MODULE_INIT_ACCEL_CPU, > so that accel-specific types can be used as parent types for all > cpu models. Use the generic TYPE_X86_CPU only if no > accel-specific specialization is enabled. Can you give more info on why this is needed and/or desirable ? Dynamically changing the class hierarchy of CPUs at runtime feels like a rather suspicious approach to me. It is contrary to work we've been doing recently to try to make all classes be fully statically defined by getting rid of dynamic properties, such that introspection of classes does not depend on other CLI flags you might have passed. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|