From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 09/16] hw/arm/armsse: Correct expansion MPC interrupt lines
Date: Tue, 10 Nov 2020 11:19:10 +0000 [thread overview]
Message-ID: <20201110111917.29539-10-peter.maydell@linaro.org> (raw)
In-Reply-To: <20201110111917.29539-1-peter.maydell@linaro.org>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
We can use one MPC per SRAM bank, but we currently only wire the
IRQ from the first expansion MPC to the IRQ splitter. Fix that.
Fixes: bb75e16d5e6 ("hw/arm/iotkit: Wire up MPC interrupt lines")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201107193403.436146-2-f4bug@amsat.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/armsse.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c
index a93da37dcbb..baac027659d 100644
--- a/hw/arm/armsse.c
+++ b/hw/arm/armsse.c
@@ -1074,7 +1074,8 @@ static void armsse_realize(DeviceState *dev, Error **errp)
qdev_get_gpio_in(dev_splitter, 0));
qdev_connect_gpio_out(dev_splitter, 0,
qdev_get_gpio_in_named(dev_secctl,
- "mpc_status", 0));
+ "mpc_status",
+ i - IOTS_NUM_EXP_MPC));
}
qdev_connect_gpio_out(dev_splitter, 1,
--
2.20.1
next prev parent reply other threads:[~2020-11-10 11:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 11:19 [PULL 00/16] target-arm queue Peter Maydell
2020-11-10 11:19 ` [PULL 01/16] hw/arm/Kconfig: ARM_V7M depends on PTIMER Peter Maydell
2020-11-10 11:19 ` [PULL 02/16] ssi: Fix bad printf format specifiers Peter Maydell
2020-11-10 11:19 ` [PULL 03/16] target/arm: add spaces around operator Peter Maydell
2020-11-10 11:19 ` [PULL 04/16] target/arm: Don't use '#' flag of printf format Peter Maydell
2020-11-10 11:19 ` [PULL 05/16] target/arm: add space before the open parenthesis '(' Peter Maydell
2020-11-10 11:19 ` [PULL 06/16] docs: add some notes on the sbsa-ref machine Peter Maydell
2020-11-10 11:19 ` [PULL 07/16] hw/arm/virt: Remove dependency on Cortex-A15 MPCore peripherals Peter Maydell
2020-11-10 11:19 ` [PULL 08/16] target/arm: Fix neon VTBL/VTBX for len > 1 Peter Maydell
2020-11-10 11:19 ` Peter Maydell [this message]
2020-11-10 11:19 ` [PULL 10/16] hw/misc/stm32f2xx_syscfg: Remove extraneous IRQ Peter Maydell
2020-11-10 11:19 ` [PULL 11/16] hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup() Peter Maydell
2020-11-10 11:19 ` [PULL 12/16] hw/arm/musicpal: Don't connect two qemu_irqs directly to the same input Peter Maydell
2020-11-10 11:19 ` [PULL 13/16] hw/arm/musicpal: Only use qdev_get_gpio_in() when necessary Peter Maydell
2020-11-10 11:19 ` [PULL 14/16] hw/arm/nseries: Check return value from load_image_targphys() Peter Maydell
2020-11-10 11:19 ` [PULL 15/16] tests/qtest/npcm7xx_rng-test: count runs properly Peter Maydell
2020-11-10 11:19 ` [PULL 16/16] target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access check Peter Maydell
2020-11-10 21:11 ` [PULL 00/16] target-arm queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110111917.29539-10-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).