From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH-for-5.2 1/2] gitlab-ci: Avoid running the OpenSBI job when not necessary
Date: Tue, 10 Nov 2020 13:16:05 +0100 [thread overview]
Message-ID: <20201110121606.2792442-2-philmd@redhat.com> (raw)
In-Reply-To: <20201110121606.2792442-1-philmd@redhat.com>
The OpenSBI jobs use the 'changes' keyword, which "makes it
possible to define if a job should be created based on files
modified by a Git push event." (see [*]). This keyword comes
with a warning:
Caution:
In pipelines with sources other than the three above
changes can’t determine if a given file is new or old
and always returns true."
In commit 922febe2af we moved the YAML config file from the
repository root directory to the .gitlab-ci.d/ directory.
We didn't respect the previous warning and disabled the
'changes' filter rule, as the files are now in a (directory)
three above the YAML config file.
As this job doesn't take much (less than 1min), run it by
default.
[*] https://docs.gitlab.com/ee/ci/yaml/#onlychangesexceptchanges
Fixes: 922febe2af ("Move edk2 and opensbi YAML files to .gitlab-ci.d folder")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.d/opensbi.yml | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index 5b13047e2ab..b1fa244fda4 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -1,10 +1,5 @@
docker-opensbi:
stage: containers
- rules: # Only run this job when the Dockerfile is modified
- - changes:
- - .gitlab-ci.d/opensbi.yml
- - .gitlab-ci.d/opensbi/Dockerfile
- when: always
image: docker:19.03.1
services:
- docker:19.03.1-dind
@@ -25,14 +20,6 @@ docker-opensbi:
build-opensbi:
stage: build
- rules: # Only run this job when ...
- - changes: # ... roms/opensbi/ is modified (submodule updated)
- - roms/opensbi/*
- when: always
- - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi'
- when: always
- - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i' # or last commit description contains 'OpenSBI'
- when: always
artifacts:
paths: # 'artifacts.zip' will contains the following files:
- pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
--
2.26.2
next prev parent reply other threads:[~2020-11-10 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:16 [PATCH-for-5.2 0/2] gitlab-ci: Fix EDK2 & OpenSBI jobs Philippe Mathieu-Daudé
2020-11-10 12:16 ` Philippe Mathieu-Daudé [this message]
2020-11-10 14:33 ` [PATCH-for-5.2 1/2] gitlab-ci: Avoid running the OpenSBI job when not necessary Daniel P. Berrangé
2020-11-10 15:07 ` Philippe Mathieu-Daudé
2020-11-10 12:16 ` [PATCH-for-5.2 2/2] gitlab-ci: Avoid running the EDK2 " Philippe Mathieu-Daudé
2020-11-10 15:35 ` Daniel P. Berrangé
2020-11-11 9:18 ` Philippe Mathieu-Daudé
2021-01-17 18:48 ` Philippe Mathieu-Daudé
2021-01-18 8:30 ` Thomas Huth
2021-01-18 9:26 ` Philippe Mathieu-Daudé
2021-01-18 10:09 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110121606.2792442-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).