From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01356C4742C for ; Wed, 11 Nov 2020 09:55:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 540282075A for ; Wed, 11 Nov 2020 09:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zo4iHpER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 540282075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcmqe-00070X-56 for qemu-devel@archiver.kernel.org; Wed, 11 Nov 2020 04:55:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcmpW-00068N-Nv for qemu-devel@nongnu.org; Wed, 11 Nov 2020 04:54:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcmpT-000139-UU for qemu-devel@nongnu.org; Wed, 11 Nov 2020 04:54:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605088455; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yp3L8s43y0hjGldhKbrFqLX0GN+STeewxqEMhIZmE6o=; b=Zo4iHpER44r/CS7zz8TdN300PoqR5NpBHfzz+4yn7s4Js5PlmS/gFBPUb+yW4RVGSyQeSc 9lMgnT6PyHd36FnB8VYt4DWLS2Ii4bfPHzfuCRFMAHopFu9brwVjh9L8Ivg/kkBzklvlZw CRL1rLe8t1t116oZ+tf6sjfGDUbtDq4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-W4cMFVKdP_WK3mj-lMeYtA-1; Wed, 11 Nov 2020 04:54:11 -0500 X-MC-Unique: W4cMFVKdP_WK3mj-lMeYtA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2D77805F18; Wed, 11 Nov 2020 09:54:09 +0000 (UTC) Received: from redhat.com (ovpn-114-221.ams2.redhat.com [10.36.114.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7146375138; Wed, 11 Nov 2020 09:53:59 +0000 (UTC) Date: Wed, 11 Nov 2020 09:53:55 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [RFC PATCH 10/16] gitlab-ci: Introduce the CI "job maintainer" concept Message-ID: <20201111095355.GB906488@redhat.com> References: <20201110160140.2859904-1-philmd@redhat.com> <20201110160140.2859904-11-philmd@redhat.com> <87o8k46xou.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87o8k46xou.fsf@linaro.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:42:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Thomas Huth , Stefan Weil , Bin Meng , Michael Tokarev , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Laszlo Ersek , virt-ci-maint-team@redhat.com, Bin Meng , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 11, 2020 at 09:37:53AM +0000, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > When a job fails, someone has to take care of it. As we can > > not wait indefinitively of volunteers good will, introduce the > > concept of "job maintainers". A job maintainer is reponsible > > of keeping it working, or contact the developers having broken > > it to fix it. > > > > When a job is added, it must have a maintainer. A job without > > maintainer is not run automatically. It can however be run > > manually from the WebUI. > > > > To declare a maintainer, it is as easy as defining the > > JOB_MAINTAINER_NAME / JOB_MAINTAINER_EMAIL environment variables. > > So I think the problem here is the CI jobs are orthogonal to the actual > tests. And the tests should be associated via MAINTAINERS with the > relevant sub-systems. > > That is not to say that the test environments don't need some care and > attention. So I'm quite happy to track updates needed to > tests/docker/dockerfiles for example but just because check-block failed > on an Ubuntu system doesn't mean I'm best placed to diagnose the > problem. In the first instance it shouldn't happen (not merging code > that regresses a test) and the second instance probably requires a block > maintainer to look at the output. > > I think a better solution is to improve our test reporting so we can > quickly point the failing tests. I notice GitLab gets nice test output > from check-acceptance. What would we need to do to improve it from > check, check-block and check-tcg? That presentation is from the artifacts publishing test results in junit format. IOW, we need to enhance the build system in some way such that it can generate a junit report of other tests too. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|