From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E89C388F9 for ; Wed, 11 Nov 2020 12:22:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BEC8206FB for ; Wed, 11 Nov 2020 12:22:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SetK7pxR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BEC8206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcp9M-0003aq-GW for qemu-devel@archiver.kernel.org; Wed, 11 Nov 2020 07:22:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcp3F-00009s-KT for qemu-devel@nongnu.org; Wed, 11 Nov 2020 07:16:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcp2R-0000PY-Tt for qemu-devel@nongnu.org; Wed, 11 Nov 2020 07:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605096946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xBJb4dN8K2GZzyLnnyot+ghewWtZKLlS9uCUuFbeQq8=; b=SetK7pxRRzzNWyeIuNZxdx4zw1JZwn8vdb6Ehw8b5FrWk2GkRNP7Ewnfw78p0T85CdlkDw vbj0lL+gRVljjfB7//4/gRZMWV/Vr6tS6753vLGHNx38cUHQ+eDdVDcrePq0whT5DlfDU5 tLnD1HGuQlFE/girnB1m7vmZ25ynmVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-ZDkk4Kd9PBWsK1Y86-7TrA-1; Wed, 11 Nov 2020 07:15:45 -0500 X-MC-Unique: ZDkk4Kd9PBWsK1Y86-7TrA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 227A980365A; Wed, 11 Nov 2020 12:15:44 +0000 (UTC) Received: from localhost (unknown [10.40.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C48C6EF7F; Wed, 11 Nov 2020 12:15:32 +0000 (UTC) Date: Wed, 11 Nov 2020 13:15:31 +0100 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v2 02/12] x86: rewrite gsi_handler() Message-ID: <20201111131531.6f72bb06@redhat.com> In-Reply-To: <20201105133923.23821-3-kraxel@redhat.com> References: <20201105133923.23821-1-kraxel@redhat.com> <20201105133923.23821-3-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:49:01 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 5 Nov 2020 14:39:13 +0100 Gerd Hoffmann wrote: > Rewrite function to use switch() for IRQ number mapping. > Check i8259_irq exists before raising it so the function > also works in case no i8259 (aka pic) is present. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/x86.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/i386/x86.c b/hw/i386/x86.c > index 5944fc44edca..b67e7b789f89 100644 > --- a/hw/i386/x86.c > +++ b/hw/i386/x86.c > @@ -588,11 +588,17 @@ void gsi_handler(void *opaque, int n, int level) > GSIState *s = opaque; > > trace_x86_gsi_interrupt(n, level); > - if (n < ISA_NUM_IRQS) { > - /* Under KVM, Kernel will forward to both PIC and IOAPIC */ > - qemu_set_irq(s->i8259_irq[n], level); > + switch (n) { > + case 0 ... ISA_NUM_IRQS - 1: > + if (s->i8259_irq[n]) { > + /* Under KVM, Kernel will forward to both PIC and IOAPIC */ > + qemu_set_irq(s->i8259_irq[n], level); > + } > + /* fall through */ > + case ISA_NUM_IRQS ... IOAPIC_NUM_PINS - 1: > + qemu_set_irq(s->ioapic_irq[n], level); > + break; > } > - qemu_set_irq(s->ioapic_irq[n], level); > } > > void ioapic_init_gsi(GSIState *gsi_state, const char *parent_name)