From: Maxim Levitsky <mlevitsk@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jan Kara <jack@suse.cz>,
qemu-block@nongnu.org,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Peter Lieven <pl@kamp.de>, Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: [PATCH 2/2] qemu-img: align next status sector on destination alignment.
Date: Wed, 11 Nov 2020 17:39:13 +0200 [thread overview]
Message-ID: <20201111153913.41840-3-mlevitsk@redhat.com> (raw)
In-Reply-To: <20201111153913.41840-1-mlevitsk@redhat.com>
This helps avoid unneeded writes and discards.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
qemu-img.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index c2c56fc797..7e9b0f659f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1722,7 +1722,7 @@ static void convert_select_part(ImgConvertState *s, int64_t sector_num,
static int convert_iteration_sectors(ImgConvertState *s, int64_t sector_num)
{
int64_t src_cur_offset;
- int ret, n, src_cur;
+ int ret, n, src_cur, alignment;
bool post_backing_zero = false;
convert_select_part(s, sector_num, &src_cur, &src_cur_offset);
@@ -1785,11 +1785,14 @@ static int convert_iteration_sectors(ImgConvertState *s, int64_t sector_num)
n = DIV_ROUND_UP(count, BDRV_SECTOR_SIZE);
/*
- * Avoid that s->sector_next_status becomes unaligned to the source
- * request alignment and/or cluster size to avoid unnecessary read
- * cycles.
+ * Avoid that s->sector_next_status becomes unaligned to the
+ * source/destination request alignment and/or cluster size to avoid
+ * unnecessary read/write cycles.
*/
- tail = (sector_num - src_cur_offset + n) % s->src_alignment[src_cur];
+ alignment = MAX(s->src_alignment[src_cur], s->alignment);
+ assert(is_power_of_2(alignment));
+
+ tail = (sector_num - src_cur_offset + n) % alignment;
if (n > tail) {
n -= tail;
}
--
2.26.2
next prev parent reply other threads:[~2020-11-11 15:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 15:39 [PATCH 0/2] RFC: Issue with discards on raw block device without O_DIRECT Maxim Levitsky
2020-11-11 15:39 ` [PATCH 1/2] file-posix: allow -EBUSY errors during write zeros on raw block devices Maxim Levitsky
2020-11-16 14:48 ` Kevin Wolf
2021-01-07 12:44 ` Maxim Levitsky
2020-11-11 15:39 ` Maxim Levitsky [this message]
2020-11-12 12:40 ` [PATCH 2/2] qemu-img: align next status sector on destination alignment Peter Lieven
2020-11-12 13:45 ` Eric Blake
2020-11-12 15:04 ` Maxim Levitsky
2021-03-18 9:57 ` Maxim Levitsky
2020-11-11 15:44 ` [PATCH 0/2] RFC: Issue with discards on raw block device without O_DIRECT Maxim Levitsky
2020-11-12 11:19 ` Jan Kara
2020-11-12 12:00 ` Jan Kara
2020-11-12 22:08 ` Darrick J. Wong
2020-12-07 17:23 ` Maxim Levitsky
2020-11-12 15:38 ` Maxim Levitsky
2020-11-13 10:07 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111153913.41840-3-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).