From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E00C388F9 for ; Wed, 11 Nov 2020 17:16:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 758EE206CA for ; Wed, 11 Nov 2020 17:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JeQlNY1z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 758EE206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kctjr-0002ZQ-4Z for qemu-devel@archiver.kernel.org; Wed, 11 Nov 2020 12:16:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kctgQ-0000GE-3j for qemu-devel@nongnu.org; Wed, 11 Nov 2020 12:13:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kctgN-0002Gn-34 for qemu-devel@nongnu.org; Wed, 11 Nov 2020 12:13:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605114796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oErL0wVoKcZy9DtWEE5Kea/0lc0f+c2S67U83tip7ag=; b=JeQlNY1ztGqC1/gl9ux/xNATeEyBVWBbKHZ5z1jXK1aUsRs72LgtxdTxu5rzogLiuG98ea opQz1r7veTGjnbE4YA9ZrPSi3onyLY0NtZVKn9rsYh944bkY10VanQoL6wWD+SB1/tdASL /WA05Zbw/hW9pEWolmLpr+z/xSWQVdc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-FyGNhPRgNHK08JOovXWI4Q-1; Wed, 11 Nov 2020 12:13:15 -0500 X-MC-Unique: FyGNhPRgNHK08JOovXWI4Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30ACA1084C83; Wed, 11 Nov 2020 17:13:14 +0000 (UTC) Received: from localhost (unknown [10.40.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 339EE5C1C4; Wed, 11 Nov 2020 17:13:08 +0000 (UTC) Date: Wed, 11 Nov 2020 18:13:06 +0100 From: Igor Mammedov To: "Dr. David Alan Gilbert" Subject: Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate Message-ID: <20201111181306.20ebdd77@redhat.com> In-Reply-To: <20201111140112.GE3232@work-vm> References: <20201019093156.2993284-1-liangpeng10@huawei.com> <20201023180933.2fe23875@redhat.com> <20201023185441.GP3038@work-vm> <20201111140112.GE3232@work-vm> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:42:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Liang , mst@redhat.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 11 Nov 2020 14:01:12 +0000 "Dr. David Alan Gilbert" wrote: > Is someone taking a fix for this in 5.2 - it's breaking vmstate > comparison. can you merge it via migration tree? [...] for fixed up version below Acked-by: Igor Mammedov > > > > Do you mean that we need another VMStateDescription to describe > > AcpiGhesState instead of using VMSTATE_UINT64 directly? Maybe like this: > > > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > > index 6df400e1ee16..5454be67d5f0 100644 > > --- a/hw/acpi/generic_event_device.c > > +++ b/hw/acpi/generic_event_device.c > > @@ -322,6 +322,16 @@ static const VMStateDescription vmstate_ged_state = { > > } > > }; > > > > +static const VMStateDescription vmstate_ghes = { > > + .name = "acpi-ghes", > > + .version_id = 1, > > + .minimum_version_id = 1, > > + .fields = (VMStateField[]) { > > + VMSTATE_UINT64(ghes_addr_le, AcpiGhesState), > > + VMSTATE_END_OF_LIST() > > + }, > > +}; > > + > > static bool ghes_needed(void *opaque) > > { > > AcpiGedState *s = opaque; > > @@ -335,7 +345,7 @@ static const VMStateDescription vmstate_ghes_state = { > > .needed = ghes_needed, > > .fields = (VMStateField[]) { > > VMSTATE_STRUCT(ghes_state, AcpiGedState, 1, > > - vmstate_ghes_state, AcpiGhesState), > > + vmstate_ghes, AcpiGhesState), > > VMSTATE_END_OF_LIST() > > } > > }; > > > > -- > > Thanks, > > Peng > >