From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: libvir-list@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, marcandre.lureau@redhat.com
Subject: Re: [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends
Date: Thu, 12 Nov 2020 11:58:00 +0100 [thread overview]
Message-ID: <20201112105800.GB14604@merkur.fritz.box> (raw)
In-Reply-To: <877dqrkmr5.fsf@dusky.pond.sub.org>
Am 12.11.2020 um 09:22 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > The aliases "tty" and "parport" are only valid on the command line, QMP
> > commands like chardev-add don't know them. query-chardev-backends should
> > describe QMP and therefore not include them in the list of available
> > backends.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> I'd call that a bug.
Which is why I'm fixing it, separate from the deprecation.
> In the light of PATCH 2, I propose to put that one first (with the
> help_string_append() hunk dropped), then remove the aliases from CLI
> help, too, like this: [...]
Going one step back without thinking in solutions immediately, what
you're suggesting is that deprecated options should become undocumented
instead of just annotated as deprecated?
Kevin
next prev parent reply other threads:[~2020-11-12 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 13:08 [PATCH 0/2] char: Deprecate backend aliases Kevin Wolf
2020-11-11 13:08 ` [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends Kevin Wolf
2020-11-12 8:22 ` Markus Armbruster
2020-11-12 10:58 ` Kevin Wolf [this message]
2020-11-13 8:01 ` Markus Armbruster
2020-11-11 13:08 ` [PATCH 2/2] char: Deprecate backend aliases 'tty' and 'parport' Kevin Wolf
2020-11-11 13:22 ` [PATCH 0/2] char: Deprecate backend aliases Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112105800.GB14604@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).