From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Dov Murik <dovmurik@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier
Date: Thu, 12 Nov 2020 14:03:03 +0000 [thread overview]
Message-ID: <20201112140303.GA13424@work-vm> (raw)
In-Reply-To: <20201109150119.GJ3024@work-vm>
* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote:
> * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> > Hi David, Juan.
> >
> > On 11/3/20 1:46 PM, Dr. David Alan Gilbert wrote:
> > > * Philippe Mathieu-Daud̮̩ (philmd@redhat.com) wrote:
> > >> The '%u' conversion specifier is for decimal notation.
> > >> When prefixing a format with '0x', we want the hexadecimal
> > >> specifier ('%x').
> > >>
> > >> Inspired-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> > >> Signed-off-by: Philippe Mathieu-Daud̮̩ <philmd@redhat.com>
> > >
> > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > As there is no qemu-trivial@ pull request during freeze/rc,
> > can you queue this patch via your migration tree?
>
> Yep, will do.
Queued
> Dave
>
> > Thanks,
> >
> > Phil.
> >
> > >
> > >> ---
> > >> migration/ram.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/migration/ram.c b/migration/ram.c
> > >> index 2da2b622ab2..23dcfb3ac38 100644
> > >> --- a/migration/ram.c
> > >> +++ b/migration/ram.c
> > >> @@ -3729,7 +3729,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block)
> > >> }
> > >>
> > >> if (end_mark != RAMBLOCK_RECV_BITMAP_ENDING) {
> > >> - error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIu64,
> > >> + error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIx64,
> > >> __func__, block->idstr, end_mark);
> > >> ret = -EINVAL;
> > >> goto out;
> > >> --
> > >> 2.26.2
> > >>
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-11-12 14:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:25 [PATCH-for-5.2 0/4] misc: Trivial format string fixes Philippe Mathieu-Daudé
2020-11-03 11:25 ` [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out Philippe Mathieu-Daudé
2020-11-03 12:42 ` Dr. David Alan Gilbert
2020-11-03 11:25 ` [PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier Philippe Mathieu-Daudé
2020-11-03 12:45 ` Dr. David Alan Gilbert
2020-11-09 14:29 ` Philippe Mathieu-Daudé
2020-11-03 11:25 ` [PATCH-for-5.2 3/4] hw/ppc/spapr_tpm_proxy: " Philippe Mathieu-Daudé
2020-11-03 11:39 ` David Gibson
2020-11-09 14:28 ` Philippe Mathieu-Daudé
2020-11-23 6:15 ` David Gibson
2020-11-03 11:40 ` Greg Kurz
2020-11-03 11:25 ` [PATCH-for-5.2 4/4] migration/ram: " Philippe Mathieu-Daudé
2020-11-03 12:46 ` Dr. David Alan Gilbert
2020-11-09 14:30 ` Philippe Mathieu-Daudé
2020-11-09 15:01 ` Dr. David Alan Gilbert
2020-11-12 14:03 ` Dr. David Alan Gilbert [this message]
2020-11-03 13:58 ` [PATCH-for-5.2 0/4] misc: Trivial format string fixes Dov Murik
2020-11-03 14:03 ` Dov Murik
2020-11-03 14:28 ` Philippe Mathieu-Daudé
2020-11-03 15:20 ` Greg Kurz
2020-11-03 15:44 ` Philippe Mathieu-Daudé
2020-11-03 15:26 ` Dov Murik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112140303.GA13424@work-vm \
--to=dgilbert@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).