From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BB0C2D0A3 for ; Thu, 12 Nov 2020 14:05:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D88620A8B for ; Thu, 12 Nov 2020 14:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V4GxTzIX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D88620A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdDDi-0006MM-QT for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 09:05:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdDC8-0005jI-HS for qemu-devel@nongnu.org; Thu, 12 Nov 2020 09:03:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdDC6-0007Jk-5e for qemu-devel@nongnu.org; Thu, 12 Nov 2020 09:03:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605189798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ny0h3imdN7DfMz48mbGmfDx8/o3TwbqhsYjQccCqzHY=; b=V4GxTzIXYuYXNbbU1wS7+1styTwNumVYnA1zjeHR9ji1hxbHeBOyB7xUAmIFiL8unVV2x7 J9byMeLmo7fk7NX4vVpayD8c+mwjSMtaV9u/LxfptIrqQjC0PSMkBs2ipH2BAICX3AyxhX +JNSosIrAAyqbHWbGR6j6QUmL3BRezU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-95chz2-KNBurMgPgxl9COg-1; Thu, 12 Nov 2020 09:03:13 -0500 X-MC-Unique: 95chz2-KNBurMgPgxl9COg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 457EE8030DE; Thu, 12 Nov 2020 14:03:12 +0000 (UTC) Received: from work-vm (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A49065D9E4; Thu, 12 Nov 2020 14:03:06 +0000 (UTC) Date: Thu, 12 Nov 2020 14:03:03 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier Message-ID: <20201112140303.GA13424@work-vm> References: <20201103112558.2554390-1-philmd@redhat.com> <20201103112558.2554390-5-philmd@redhat.com> <20201103124634.GG3566@work-vm> <20201109150119.GJ3024@work-vm> MIME-Version: 1.0 In-Reply-To: <20201109150119.GJ3024@work-vm> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 00:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , qemu-devel@nongnu.org, Dov Murik , qemu-ppc@nongnu.org, Gerd Hoffmann , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > > Hi David, Juan. > > > > On 11/3/20 1:46 PM, Dr. David Alan Gilbert wrote: > > > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > > >> The '%u' conversion specifier is for decimal notation. > > >> When prefixing a format with '0x', we want the hexadecimal > > >> specifier ('%x'). > > >> > > >> Inspired-by: Dov Murik > > >> Signed-off-by: Philippe Mathieu-Daudé > > > > > > Reviewed-by: Dr. David Alan Gilbert > > > > As there is no qemu-trivial@ pull request during freeze/rc, > > can you queue this patch via your migration tree? > > Yep, will do. Queued > Dave > > > Thanks, > > > > Phil. > > > > > > > >> --- > > >> migration/ram.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/migration/ram.c b/migration/ram.c > > >> index 2da2b622ab2..23dcfb3ac38 100644 > > >> --- a/migration/ram.c > > >> +++ b/migration/ram.c > > >> @@ -3729,7 +3729,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block) > > >> } > > >> > > >> if (end_mark != RAMBLOCK_RECV_BITMAP_ENDING) { > > >> - error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIu64, > > >> + error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIx64, > > >> __func__, block->idstr, end_mark); > > >> ret = -EINVAL; > > >> goto out; > > >> -- > > >> 2.26.2 > > >> > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK