From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6912AC2D0A3 for ; Thu, 12 Nov 2020 14:52:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A710920872 for ; Thu, 12 Nov 2020 14:52:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SYy8C2GY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A710920872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdDxG-0005aw-D1 for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 09:52:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdDv1-0003kl-M3 for qemu-devel@nongnu.org; Thu, 12 Nov 2020 09:49:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdDuz-0006Ts-3C for qemu-devel@nongnu.org; Thu, 12 Nov 2020 09:49:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605192582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bs/0GTEc9jblJWVx4QgmwZ2gt+QsfH1zqzvOiwogq2Q=; b=SYy8C2GYlNaBVKpQj7HR68ug6veVwM7MvOiWgdEB7coXgqgVIUVI4xp8JyJwkUuu+1FWMS cl05haT06FjE8f3MFEgJniHsL+TTh5vkpMg1VFcw8/g3KtwH8eoJO37P0L2TI13FWGUe53 eWlo/3oI7oJI/Pr3H14+9VxzCJMmHk8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-HBOt5A6sNHyutTLXSAAVAw-1; Thu, 12 Nov 2020 09:49:40 -0500 X-MC-Unique: HBOt5A6sNHyutTLXSAAVAw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A535C593B2; Thu, 12 Nov 2020 14:49:38 +0000 (UTC) Received: from work-vm (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9351D73679; Thu, 12 Nov 2020 14:49:36 +0000 (UTC) Date: Thu, 12 Nov 2020 14:49:33 +0000 From: "Dr. David Alan Gilbert" To: Chen Qun Subject: Re: [PATCH v2 5/5] migration: fix uninitialized variable warning in migrate_send_rp_req_pages() Message-ID: <20201112144933.GD13424@work-vm> References: <20201111142203.2359370-1-kuhn.chenqun@huawei.com> <20201111142203.2359370-6-kuhn.chenqun@huawei.com> MIME-Version: 1.0 In-Reply-To: <20201111142203.2359370-6-kuhn.chenqun@huawei.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 00:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Juan Quintela , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, ganqixin@huawei.com, Euler Robot , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Chen Qun (kuhn.chenqun@huawei.com) wrote: > After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify > that the statements in the macro must be executed. As a result, some variables > assignment statements in the macro may be considered as unexecuted by the compiler. > > When the -Wmaybe-uninitialized capability is enabled on GCC9,the compiler showed warning: > migration/migration.c: In function ‘migrate_send_rp_req_pages’: > migration/migration.c:384:8: warning: ‘received’ may be used uninitialized in this function [-Wmaybe-uninitialized] > 384 | if (received) { > | ^ > > Add a default value for 'received' to prevented the warning. > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > Reviewed-by: Philippe Mathieu-Daudé Queuing this one via migration > --- > Cc: Juan Quintela > Cc: "Dr. David Alan Gilbert" > --- > migration/migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migration/migration.c > index 9bb4fee5ac..de90486a61 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -361,7 +361,7 @@ int migrate_send_rp_req_pages(MigrationIncomingState *mis, > RAMBlock *rb, ram_addr_t start, uint64_t haddr) > { > void *aligned = (void *)(uintptr_t)(haddr & (-qemu_ram_pagesize(rb))); > - bool received; > + bool received = false; > > WITH_QEMU_LOCK_GUARD(&mis->page_request_mutex) { > received = ramblock_recv_bitmap_test_byte_offset(rb, start); > -- > 2.27.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK