From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C91BC2D0A3 for ; Thu, 12 Nov 2020 15:32:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B0B822248 for ; Thu, 12 Nov 2020 15:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IIbGgILb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B0B822248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdEZu-0007eB-0b for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 10:32:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdEZ2-00078R-Nu for qemu-devel@nongnu.org; Thu, 12 Nov 2020 10:31:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdEZ1-0005sr-1p for qemu-devel@nongnu.org; Thu, 12 Nov 2020 10:31:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605195066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IYWuC6oHHbU1l9fl3TFRLzGm2XxYMB534tQq0UN/aoc=; b=IIbGgILbRRcG5Pd+7vQK/6KENb2alXK/25tJoiovRvHCUdjlTfS6Z7z10Ix/LK+bJdTPuE VU/GDoiqT71w0dfb+tjJOOBXdUbPi6jusSdpokGQZxhRDmenSeXgJGy/OUB6/UIkOUUdR/ 3SP0Ux6WAO0vCZ17LhLG+wlp2A1UnAw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-EK_tA9pAPW68K-2L8h9Xog-1; Thu, 12 Nov 2020 10:31:04 -0500 X-MC-Unique: EK_tA9pAPW68K-2L8h9Xog-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2827A802B46; Thu, 12 Nov 2020 15:31:03 +0000 (UTC) Received: from work-vm (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0EEC5D9CA; Thu, 12 Nov 2020 15:31:01 +0000 (UTC) Date: Thu, 12 Nov 2020 15:30:58 +0000 From: "Dr. David Alan Gilbert" To: "Longpeng(Mike)" Subject: Re: [PATCH] migration: handle CANCELLING state in migration_completion() Message-ID: <20201112153058.GF13424@work-vm> References: <20201105091726.148-1-longpeng2@huawei.com> MIME-Version: 1.0 In-Reply-To: <20201105091726.148-1-longpeng2@huawei.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 00:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arei.gonglei@huawei.com, huangzhichao@huawei.com, qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Longpeng(Mike) (longpeng2@huawei.com) wrote: > The following sequence may cause the VM abort during migration: > > 1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE > > 2. before call migration_completion(), we send migrate_cancel > QMP command, the state machine is changed to: > RUN_STATE_RUNNING,MIGRATION_STATUS_CANCELLING > > 3. call migration_completion(), and the state machine is > switch to: RUN_STATE_RUNNING,MIGRATION_STATUS_COMPLETED > > 4. call migration_iteration_finish(), because the migration > status is COMPLETED, so it will try to set the runstate > to POSTMIGRATE, but RUNNING-->POSTMIGRATE is an invalid > transition, so abort(). > > The migration_completion() should not change the migration state > to COMPLETED if it is already changed to CANCELLING. > > Signed-off-by: Longpeng(Mike) Queued > --- > migration/migration.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/migration/migration.c b/migration/migration.c > index 3263aa5..b11a2bd 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -3061,6 +3061,8 @@ static void migration_completion(MigrationState *s) > > qemu_savevm_state_complete_postcopy(s->to_dst_file); > trace_migration_completion_postcopy_end_after_complete(); > + } else if (s->state == MIGRATION_STATUS_CANCELLING) { > + goto fail; > } > > /* > -- > 1.8.3.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK