From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() get Object* argument
Date: Fri, 13 Nov 2020 12:26:38 +0100 [thread overview]
Message-ID: <20201113122638.1238716b.cohuck@redhat.com> (raw)
In-Reply-To: <20201112214350.872250-13-ehabkost@redhat.com>
On Thu, 12 Nov 2020 16:43:09 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: qemu-devel@nongnu.org
> Cc: qemu-s390x@nongnu.org
> ---
> include/hw/qdev-properties.h | 2 +-
> hw/core/qdev-properties-system.c | 10 +++++-----
> hw/core/qdev-properties.c | 10 +++++-----
> hw/s390x/css.c | 2 +-
> 4 files changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com> #s390 parts
next prev parent reply other threads:[~2020-11-13 11:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 21:42 [PATCH v3 00/53] Make qdev static property API usable by any QOM type Eduardo Habkost
2020-11-12 21:42 ` [PATCH v3 01/53] cs4231: Get rid of empty property array Eduardo Habkost
2020-11-12 21:42 ` [PATCH v3 02/53] cpu: Move cpu_common_props to hw/core/cpu.c Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 03/53] qdev: Move property code to qdev-properties.[ch] Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 04/53] qdev: Check dev->realized at set_size() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 05/53] sparc: Check dev->realized at sparc_set_nwindows() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 06/53] qdev: Don't use dev->id on set_size32() error message Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 07/53] qdev: Make PropertyInfo.print method get Object* argument Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 08/53] qdev: Make bit_prop_set() " Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg Eduardo Habkost
2020-11-13 11:23 ` Cornelia Huck
2020-11-12 21:43 ` [PATCH v3 10/53] qdev: Make qdev_find_global_prop() get Object* argument Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 11/53] qdev: Make check_prop_still_unset() " Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() " Eduardo Habkost
2020-11-13 11:26 ` Cornelia Huck [this message]
2020-11-12 21:43 ` [PATCH v3 13/53] qdev: Make qdev_propinfo_get_uint16() static Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 14/53] qdev: Move UUID property to qdev-properties-system.c Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 15/53] qdev: Move softmmu properties to qdev-properties-system.h Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 16/53] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 18/53] qdev: Get just property name at error_set_from_qdev_prop_error() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 19/53] qdev: Avoid using prop->name unnecessarily Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 20/53] qdev: Add name parameter to qdev_class_add_property() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 21/53] qdev: Add name argument to PropertyInfo.create method Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 22/53] qdev: Wrap getters and setters in separate helpers Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 23/53] qdev: Move dev->realized check to qdev_property_set() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 24/53] qdev: Make PropertyInfo.create return ObjectProperty* Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 25/53] qdev: Make qdev_class_add_property() more flexible Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 26/53] qdev: Separate generic and device-specific property registration Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 27/53] qdev: Rename qdev_propinfo_* to field_prop_* Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 28/53] qdev: Move qdev_prop_tpm declaration to tpm_prop.h Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 29/53] qdev: Rename qdev_prop_* to prop_info_* Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 30/53] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 31/53] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 32/53] tests: Add unit test for qdev array properties Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 33/53] qom: Add allow_set callback to ObjectProperty Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 34/53] qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 35/53] qdev: Rename Property.name to Property.name_template Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 36/53] qdev: Don't set .name_template for array elements Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 37/53] qdev: Remove ArrayElementProperty.propname field Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 38/53] qdev: Remove ArrayElementProperty.release field Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 39/53] qdev: Get rid of ArrayElementProperty struct Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 40/53] qdev: Rename array_element_release() to static_prop_release_dynamic_prop() Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 41/53] qdev: Make object_property_add_field() copy the Property struct Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 42/53] qdev: Reuse object_property_add_field() when adding array elements Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 43/53] qdev: Move static_prop_release_dynamic_prop() closer to its usage Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 44/53] qom: Add new qom.h header Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 45/53] qdev: Move core field property code to QOM Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 46/53] qdev: Move base property types to qom/property-types.c Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 47/53] qom: Include static property API reference in documentation Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 48/53] qom: object_class_property_add_field() function Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 49/53] qom: FIELD_PROP macro Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 50/53] qom: Delete DEFINE_PROP_*SIGNED_NODEFAULT macro Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 51/53] qom: PROP_* macros Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 52/53] tests: Use field property at check-qom-proplist test case Eduardo Habkost
2020-11-12 21:43 ` [PATCH v3 53/53] sev: Use class properties Eduardo Habkost
2020-12-11 22:08 ` [PATCH v3 00/53] Make qdev static property API usable by any QOM type Eduardo Habkost
2020-12-11 22:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113122638.1238716b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).