From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dov Murik" <dovmurik@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [PULL 5/6] hw/display/cirrus_vga: Fix hexadecimal format string specifier
Date: Fri, 13 Nov 2020 13:29:54 +0100 [thread overview]
Message-ID: <20201113122955.759-6-kraxel@redhat.com> (raw)
In-Reply-To: <20201113122955.759-1-kraxel@redhat.com>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The '%u' conversion specifier is for decimal notation.
When prefixing a format with '0x', we want the hexadecimal
specifier ('%x').
Inspired-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-id: 20201103112558.2554390-3-philmd@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/cirrus_vga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index e14096deb46a..fdca6ca659f9 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -2105,7 +2105,7 @@ static void cirrus_vga_mem_write(void *opaque,
} else {
qemu_log_mask(LOG_GUEST_ERROR,
"cirrus: mem_writeb 0x" TARGET_FMT_plx " "
- "value 0x%02" PRIu64 "\n", addr, mem_value);
+ "value 0x%02" PRIx64 "\n", addr, mem_value);
}
}
--
2.27.0
next prev parent reply other threads:[~2020-11-13 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:29 [PULL 0/6] Fixes 20201113 patches Gerd Hoffmann
2020-11-13 12:29 ` [PULL 1/6] audio/jack: fix use after free segfault Gerd Hoffmann
2020-11-13 12:29 ` [PULL 2/6] console: avoid passing con=NULL to graphic_hw_update_done() Gerd Hoffmann
2020-11-13 12:29 ` [PULL 3/6] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI) Gerd Hoffmann
2020-11-13 12:29 ` [PULL 4/6] hw/display/cirrus_vga: Remove debugging code commented out Gerd Hoffmann
2020-11-13 12:29 ` Gerd Hoffmann [this message]
2020-11-13 12:29 ` [PULL 6/6] xhci: fix nec-usb-xhci properties Gerd Hoffmann
2020-11-13 13:40 ` [PULL 0/6] Fixes 20201113 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113122955.759-6-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).