From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ADFC4742C for ; Fri, 13 Nov 2020 12:46:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60B3620A8B for ; Fri, 13 Nov 2020 12:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VwPIRq8p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60B3620A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdYTB-0000Hr-FY for qemu-devel@archiver.kernel.org; Fri, 13 Nov 2020 07:46:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdYRS-0007pc-Ak for qemu-devel@nongnu.org; Fri, 13 Nov 2020 07:44:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdYRQ-00079P-Gp for qemu-devel@nongnu.org; Fri, 13 Nov 2020 07:44:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605271475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2ZXbcMpv3Fg9WP0rhbpmCnWuW8VkSA8CdeX26SrxCZA=; b=VwPIRq8pv/sVvA0tShKPpBo0pLk5z/EvkT/NevS6ZIpG4Hqgj0MIwzexyUtZU82UQuP7O+ CB6OnP2yY+kt6qRPKNhAaP5sxvkWu2sgNSnzl/huQArXavYt6DACGYDNVp+TRslMuEhiAU 7VId259YrRZJarAX6y5STPN1q0WPGUY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-hH5ICsmPM0ORJEN1jUzWMQ-1; Fri, 13 Nov 2020 07:44:33 -0500 X-MC-Unique: hH5ICsmPM0ORJEN1jUzWMQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F2F5108BBE0; Fri, 13 Nov 2020 12:44:18 +0000 (UTC) Received: from work-vm (ovpn-114-160.ams2.redhat.com [10.36.114.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B7125C1C2; Fri, 13 Nov 2020 12:44:15 +0000 (UTC) Date: Fri, 13 Nov 2020 12:44:13 +0000 From: "Dr. David Alan Gilbert" To: Kevin Wolf Subject: Re: [PATCH for-5.2 0/3] hmp: Fix arg evaluation crash (regression) Message-ID: <20201113124413.GK3251@work-vm> References: <20201113114326.97663-1-kwolf@redhat.com> <20201113121311.GI3251@work-vm> <20201113124305.GD5834@merkur.fritz.box> MIME-Version: 1.0 In-Reply-To: <20201113124305.GD5834@merkur.fritz.box> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 08:00:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, lichun@ruijie.com.cn, qemu-devel@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Kevin Wolf (kwolf@redhat.com) wrote: > Am 13.11.2020 um 13:13 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kwolf@redhat.com) wrote: > > > When I restricted the section where the current monitor is set to only > > > the command handler, I missed that monitor_parse_arguments() can use it > > > indirectly, too, when evaluating register variables. These cases get > > > NULL now and crash (easy to reproduce with "x $pc"). > > > > > > This series passes the right monitor object down instead of using > > > monitor_cur(), which fixes the crash. > > > > Why didn't the test-hmp.c find this? It has a 'p $pc + 8' > > Good question, a manual 'p $pc + 8' crashes for me on master. > > Aha, it doesn't use a real HMP monitor, but QMP human-monitor-command. > Then it would just get the wrong monitor (the QMP one instead of the > temporary HMP monitor) and not NULL. The accessed CPU is even the same > because neither QMP nor the temporary HMP monitor have a current CPU > set, so even if the test case did check the result, it wouldn't catch > this. > > Only if the test case were using multiple CPUs and cpu-index had been > set for human-monitor-command (to something other than the default), we > would get a wrong result. But of course, it still wouldn't crash. Ah, fair enough. Dave > Kevin -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK