* [PATCH] configure: Force-remove temp dir
@ 2020-11-13 16:22 Dan Church
2020-11-13 16:33 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Dan Church @ 2020-11-13 16:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Dan Church
Sometimes the compiler will leave a write-protected .o file in the temp
directory, and GNU rm will ask before deleting it unless -f is
specified.
Signed-off-by: Dan Church <amphetamachine@gmail.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4cef321d9d..663b91a334 100755
--- a/configure
+++ b/configure
@@ -7080,4 +7080,4 @@ done
echo ' "$@"' >>config.status
chmod +x config.status
-rm -r "$TMPDIR1"
+rm -rf "$TMPDIR1"
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Force-remove temp dir
2020-11-13 16:22 [PATCH] configure: Force-remove temp dir Dan Church
@ 2020-11-13 16:33 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-11-13 16:33 UTC (permalink / raw)
To: Dan Church; +Cc: QEMU Developers
On Fri, 13 Nov 2020 at 16:26, Dan Church <amphetamachine@gmail.com> wrote:
>
> Sometimes the compiler will leave a write-protected .o file in the temp
> directory, and GNU rm will ask before deleting it unless -f is
> specified.
>
> Signed-off-by: Dan Church <amphetamachine@gmail.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4cef321d9d..663b91a334 100755
> --- a/configure
> +++ b/configure
> @@ -7080,4 +7080,4 @@ done
> echo ' "$@"' >>config.status
> chmod +x config.status
>
> -rm -r "$TMPDIR1"
> +rm -rf "$TMPDIR1"
We rm -rf this directory at the top of configure, so it seems
like an oversight that we don't use '-f' here at the bottom too.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
You should probably look into why your compiler is generating
write-protected .o files, though -- that doesn't sound normal.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] configure: Force-remove temp dir
@ 2020-11-13 16:11 Dan Church
0 siblings, 0 replies; 3+ messages in thread
From: Dan Church @ 2020-11-13 16:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Dan Church
Sometimes the compiler will leave a write-protected .o file in the temp
directory, and GNU rm will ask before deleting it unless -f is
specified.
Signed-off-by: Dan Church <amphetamachine@gmail.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4cef321d9d..663b91a334 100755
--- a/configure
+++ b/configure
@@ -7080,4 +7080,4 @@ done
echo ' "$@"' >>config.status
chmod +x config.status
-rm -r "$TMPDIR1"
+rm -rf "$TMPDIR1"
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-13 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-13 16:22 [PATCH] configure: Force-remove temp dir Dan Church
2020-11-13 16:33 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2020-11-13 16:11 Dan Church
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).