From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs
Date: Fri, 13 Nov 2020 17:45:57 +0000 [thread overview]
Message-ID: <20201113174557.GL30434@redhat.com> (raw)
In-Reply-To: <20201113174404.19608-1-alex.bennee@linaro.org>
On Fri, Nov 13, 2020 at 05:44:04PM +0000, Alex Bennée wrote:
> We don't need running commentary for the CI logs and by keeping it
> short we might just see the problem on the first page. While we are at
> it flush the previous line so order is maintained between script and
> sub process.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/check-patch.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py
> index 0ff30ee077..39e2b403c9 100755
> --- a/.gitlab-ci.d/check-patch.py
> +++ b/.gitlab-ci.d/check-patch.py
> @@ -45,9 +45,9 @@ if log == "":
>
> errors = False
>
> -print("\nChecking all commits since %s...\n" % ancestor)
> +print("\nChecking all commits since %s...\n" % ancestor, flush=True)
>
> -ret = subprocess.run(["scripts/checkpatch.pl", ancestor + "..."])
> +ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."])
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2020-11-13 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 17:44 [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs Alex Bennée
2020-11-13 17:45 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113174557.GL30434@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).