* [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs
@ 2020-11-13 17:44 Alex Bennée
2020-11-13 17:45 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2020-11-13 17:44 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Thomas Huth, berrange,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
We don't need running commentary for the CI logs and by keeping it
short we might just see the problem on the first page. While we are at
it flush the previous line so order is maintained between script and
sub process.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.gitlab-ci.d/check-patch.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py
index 0ff30ee077..39e2b403c9 100755
--- a/.gitlab-ci.d/check-patch.py
+++ b/.gitlab-ci.d/check-patch.py
@@ -45,9 +45,9 @@ if log == "":
errors = False
-print("\nChecking all commits since %s...\n" % ancestor)
+print("\nChecking all commits since %s...\n" % ancestor, flush=True)
-ret = subprocess.run(["scripts/checkpatch.pl", ancestor + "..."])
+ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."])
if ret.returncode != 0:
print(" ❌ FAIL one or more commits failed scripts/checkpatch.pl")
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs
2020-11-13 17:44 [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs Alex Bennée
@ 2020-11-13 17:45 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2020-11-13 17:45 UTC (permalink / raw)
To: Alex Bennée
Cc: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel,
Wainer dos Santos Moschetta
On Fri, Nov 13, 2020 at 05:44:04PM +0000, Alex Bennée wrote:
> We don't need running commentary for the CI logs and by keeping it
> short we might just see the problem on the first page. While we are at
> it flush the previous line so order is maintained between script and
> sub process.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/check-patch.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py
> index 0ff30ee077..39e2b403c9 100755
> --- a/.gitlab-ci.d/check-patch.py
> +++ b/.gitlab-ci.d/check-patch.py
> @@ -45,9 +45,9 @@ if log == "":
>
> errors = False
>
> -print("\nChecking all commits since %s...\n" % ancestor)
> +print("\nChecking all commits since %s...\n" % ancestor, flush=True)
>
> -ret = subprocess.run(["scripts/checkpatch.pl", ancestor + "..."])
> +ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."])
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-13 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-13 17:44 [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs Alex Bennée
2020-11-13 17:45 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).