From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alexander von Gluck IV" <kallisti5@unixzen.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"David CARLIER" <devnexen@gmail.com>,
kraxel@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h
Date: Sat, 14 Nov 2020 17:51:36 +0100 [thread overview]
Message-ID: <20201114165137.15379-4-thuth@redhat.com> (raw)
In-Reply-To: <20201114165137.15379-1-thuth@redhat.com>
On Solaris and Haiku, the _IO() macros are defined in <sys/ioccom.h>.
Add a proper check for this header to our configure scripts, and
make sure to include the header in tpm_ioctl.h to fix a build failure
on Solaris and Haiku.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
backends/tpm/tpm_ioctl.h | 4 ++++
configure | 11 ++++++++++-
nbd/nbd-internal.h | 2 +-
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/backends/tpm/tpm_ioctl.h b/backends/tpm/tpm_ioctl.h
index f5f5c553a9..bd6c12cb86 100644
--- a/backends/tpm/tpm_ioctl.h
+++ b/backends/tpm/tpm_ioctl.h
@@ -12,6 +12,10 @@
#include <sys/uio.h>
#include <sys/ioctl.h>
+#ifdef HAVE_SYS_IOCCOM_H
+#include <sys/ioccom.h>
+#endif
+
/*
* Every response from a command involving a TPM command execution must hold
* the ptm_res as the first element.
diff --git a/configure b/configure
index c0acda164d..764e903748 100755
--- a/configure
+++ b/configure
@@ -3123,6 +3123,13 @@ if check_include "sys/signal.h" ; then
have_sys_signal_h=yes
fi
+#########################################
+# sys/ioccom.h check
+have_sys_ioccom_h=no
+if check_include "sys/ioccom.h" ; then
+ have_sys_ioccom_h=yes
+fi
+
##########################################
# VTE probe
@@ -6214,7 +6221,9 @@ fi
if test "$have_sys_signal_h" = "yes" ; then
echo "HAVE_SYS_SIGNAL_H=y" >> $config_host_mak
fi
-
+if test "$have_sys_ioccom_h" = "yes" ; then
+ echo "HAVE_SYS_IOCCOM_H=y" >> $config_host_mak
+fi
# Work around a system header bug with some kernel/XFS header
# versions where they both try to define 'struct fsxattr':
# xfs headers will not try to redefine structs from linux headers
diff --git a/nbd/nbd-internal.h b/nbd/nbd-internal.h
index 60629ef160..1b2141ab4b 100644
--- a/nbd/nbd-internal.h
+++ b/nbd/nbd-internal.h
@@ -19,7 +19,7 @@
#ifndef _WIN32
#include <sys/ioctl.h>
#endif
-#if defined(__sun__) || defined(__HAIKU__)
+#ifdef HAVE_SYS_IOCCOM_H
#include <sys/ioccom.h>
#endif
--
2.18.4
next prev parent reply other threads:[~2020-11-14 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:51 [PATCH for-5.2? 0/4] Fix build failures on Haiku Thomas Huth
2020-11-14 16:51 ` [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-14 16:51 ` [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` Thomas Huth [this message]
2020-11-14 16:56 ` [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h 罗勇刚(Yonggang Luo)
2020-11-15 14:00 ` Thomas Huth
2020-11-15 14:34 ` Paolo Bonzini
2020-11-15 15:18 ` Thomas Huth
2020-11-14 23:43 ` Stefan Berger
2020-11-15 15:23 ` [PATCH v2 " Thomas Huth
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 4/4] tests/vm: Add Haiku test based on their vagrant images Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114165137.15379-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=devnexen@gmail.com \
--cc=f4bug@amsat.org \
--cc=kallisti5@unixzen.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).