From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Chen <alex.chen@huawei.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
marcandre.lureau@redhat.com, QEMU <qemu-devel@nongnu.org>,
stefanha@redhat.com,
Raphael Norwitz <raphael.norwitz@nutanix.com>
Subject: Re: [PATCH] contrib/libvhost-user: Fix bad printf format specifiers
Date: Mon, 16 Nov 2020 04:52:49 -0500 [thread overview]
Message-ID: <20201116045218-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5FB1E074.50205@huawei.com>
It's in the latest pull weren't you Cc'd?
On Mon, Nov 16, 2020 at 10:14:12AM +0800, Alex Chen wrote:
> Kindly ping...
>
> On 2020/11/4 18:23, AlexChen wrote:
> > We should use printf format specifier "%u" instead of "%d" for
> > argument of type "unsigned int".
> >
> > Reported-by: Euler Robot <euler.robot@huawei.com>
> > Signed-off-by: Alex Chen <alex.chen@huawei.com>
> > ---
> > contrib/libvhost-user/libvhost-user.c | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
> > index bfec8a881a..5c73ffdd6b 100644
> > --- a/contrib/libvhost-user/libvhost-user.c
> > +++ b/contrib/libvhost-user/libvhost-user.c
> > @@ -701,7 +701,7 @@ vu_add_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
> > return false;
> > }
> >
> > - DPRINT("Adding region: %d\n", dev->nregions);
> > + DPRINT("Adding region: %u\n", dev->nregions);
> > DPRINT(" guest_phys_addr: 0x%016"PRIx64"\n",
> > msg_region->guest_phys_addr);
> > DPRINT(" memory_size: 0x%016"PRIx64"\n",
> > @@ -848,7 +848,7 @@ vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)
> > VhostUserMemory m = vmsg->payload.memory, *memory = &m;
> > dev->nregions = memory->nregions;
> >
> > - DPRINT("Nregions: %d\n", memory->nregions);
> > + DPRINT("Nregions: %u\n", memory->nregions);
> > for (i = 0; i < dev->nregions; i++) {
> > void *mmap_addr;
> > VhostUserMemoryRegion *msg_region = &memory->regions[i];
> > @@ -938,7 +938,7 @@ vu_set_mem_table_exec(VuDev *dev, VhostUserMsg *vmsg)
> > return vu_set_mem_table_exec_postcopy(dev, vmsg);
> > }
> >
> > - DPRINT("Nregions: %d\n", memory->nregions);
> > + DPRINT("Nregions: %u\n", memory->nregions);
> > for (i = 0; i < dev->nregions; i++) {
> > void *mmap_addr;
> > VhostUserMemoryRegion *msg_region = &memory->regions[i];
> > @@ -1049,8 +1049,8 @@ vu_set_vring_num_exec(VuDev *dev, VhostUserMsg *vmsg)
> > unsigned int index = vmsg->payload.state.index;
> > unsigned int num = vmsg->payload.state.num;
> >
> > - DPRINT("State.index: %d\n", index);
> > - DPRINT("State.num: %d\n", num);
> > + DPRINT("State.index: %u\n", index);
> > + DPRINT("State.num: %u\n", num);
> > dev->vq[index].vring.num = num;
> >
> > return false;
> > @@ -1105,8 +1105,8 @@ vu_set_vring_base_exec(VuDev *dev, VhostUserMsg *vmsg)
> > unsigned int index = vmsg->payload.state.index;
> > unsigned int num = vmsg->payload.state.num;
> >
> > - DPRINT("State.index: %d\n", index);
> > - DPRINT("State.num: %d\n", num);
> > + DPRINT("State.index: %u\n", index);
> > + DPRINT("State.num: %u\n", num);
> > dev->vq[index].shadow_avail_idx = dev->vq[index].last_avail_idx = num;
> >
> > return false;
> > @@ -1117,7 +1117,7 @@ vu_get_vring_base_exec(VuDev *dev, VhostUserMsg *vmsg)
> > {
> > unsigned int index = vmsg->payload.state.index;
> >
> > - DPRINT("State.index: %d\n", index);
> > + DPRINT("State.index: %u\n", index);
> > vmsg->payload.state.num = dev->vq[index].last_avail_idx;
> > vmsg->size = sizeof(vmsg->payload.state);
> >
> > @@ -1478,8 +1478,8 @@ vu_set_vring_enable_exec(VuDev *dev, VhostUserMsg *vmsg)
> > unsigned int index = vmsg->payload.state.index;
> > unsigned int enable = vmsg->payload.state.num;
> >
> > - DPRINT("State.index: %d\n", index);
> > - DPRINT("State.enable: %d\n", enable);
> > + DPRINT("State.index: %u\n", index);
> > + DPRINT("State.enable: %u\n", enable);
> >
> > if (index >= dev->max_queues) {
> > vu_panic(dev, "Invalid vring_enable index: %u", index);
> > @@ -1728,7 +1728,7 @@ vu_handle_vring_kick(VuDev *dev, VhostUserMsg *vmsg)
> > return false;
> > }
> >
> > - DPRINT("Got kick message: handler:%p idx:%d\n",
> > + DPRINT("Got kick message: handler:%p idx:%u\n",
> > dev->vq[index].handler, index);
> >
> > if (!dev->vq[index].started) {
> > @@ -1772,7 +1772,7 @@ vu_process_message(VuDev *dev, VhostUserMsg *vmsg)
> > DPRINT("Request: %s (%d)\n", vu_request_to_string(vmsg->request),
> > vmsg->request);
> > DPRINT("Flags: 0x%x\n", vmsg->flags);
> > - DPRINT("Size: %d\n", vmsg->size);
> > + DPRINT("Size: %u\n", vmsg->size);
> >
> > if (vmsg->fd_num) {
> > int i;
> >
next prev parent reply other threads:[~2020-11-16 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:23 [PATCH] contrib/libvhost-user: Fix bad printf format specifiers AlexChen
2020-11-16 2:14 ` Alex Chen
2020-11-16 9:52 ` Michael S. Tsirkin [this message]
2020-11-16 11:13 ` Alex Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116045218-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.chen@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).