From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: peter.maydell@linaro.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off
Date: Mon, 16 Nov 2020 08:27:19 -0500 [thread overview]
Message-ID: <20201116082603-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <46c6a76d-348f-4351-656c-8ec4b07f8f8b@redhat.com>
On Mon, Nov 16, 2020 at 02:11:35PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/16/20 1:27 PM, Michael S. Tsirkin wrote:
> > On Mon, Nov 16, 2020 at 12:24:15PM +0000, Alex Bennée wrote:
> >> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>
> >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
> >> is already in the "if (bsel || pcihp_bridge_en)" block statement,
> >> but it isn't smart enough to figure it out.
> >>
> >> Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)"
> >> block statement to fix (on Ubuntu):
> >>
> >> ../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
> >> ../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized
> >> in this function [-Werror=maybe-uninitialized]
> >> 496 | aml_append(parent_scope, method);
> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> cc1: all warnings being treated as errors
> >>
> >> Fixes: df4008c9c59 ("piix4: don't reserve hw resources when hotplug is off globally")
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> >> Message-Id: <20201108204535.2319870-4-philmd@redhat.com>
> >> Message-Id: <20201110192316.26397-8-alex.bennee@linaro.org>
> >
> > BTW it's in my pull request alredy.
> > Not sure why you are merging it too ...
>
> I suppose to unbreak Gitlab-CI...
>
> There is no policy w.r.t. CI so maintainer don't have to use it,
> but this breaking it delay the workflow of others subsystems.
>
> I'm not asking you to use it, just explaining why this patch is
> in Alex's queue.
>
> Regards,
>
> Phil.
Not sure I understand.
It's in my pull request from Nov 15. I'm not sure how does it
help anyone to also have it in another request from Nov 16...
--
MST
next prev parent reply other threads:[~2020-11-16 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 12:24 [PULL 0/9] various fixes (CI, Xen, warnings) Alex Bennée
2020-11-16 12:24 ` [PULL 1/9] plugins: Fix resource leak in connect_socket() Alex Bennée
2020-11-16 12:24 ` [PULL 2/9] plugins: Fix two resource leaks in setup_socket() Alex Bennée
2020-11-16 12:24 ` [PULL 3/9] meson.build: fix building of Xen support for aarch64 Alex Bennée
2020-11-16 12:24 ` [PULL 4/9] include/hw/xen.h: drop superfluous struct Alex Bennée
2020-11-16 12:24 ` [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub Alex Bennée
2020-11-16 12:24 ` [PULL 6/9] accel/stubs: drop unused cpu.h include Alex Bennée
2020-11-16 12:24 ` [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Alex Bennée
2020-11-16 12:27 ` Michael S. Tsirkin
2020-11-16 13:11 ` Philippe Mathieu-Daudé
2020-11-16 13:27 ` Michael S. Tsirkin [this message]
2020-11-16 16:01 ` Alex Bennée
2020-11-16 12:24 ` [PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test Alex Bennée
2020-11-16 12:24 ` [PULL 9/9] .gitlab-ci.d/check-patch: tweak output for CI logs Alex Bennée
2020-11-16 17:00 ` [PULL 0/9] various fixes (CI, Xen, warnings) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116082603-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).