From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alex Chen" <alex.chen@huawei.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Euler Robot" <euler.robot@huawei.com>
Subject: [PULL 1/9] plugins: Fix resource leak in connect_socket()
Date: Mon, 16 Nov 2020 12:24:09 +0000 [thread overview]
Message-ID: <20201116122417.28346-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201116122417.28346-1-alex.bennee@linaro.org>
From: Alex Chen <alex.chen@huawei.com>
Close the fd when the connect() fails.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-2-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-2-alex.bennee@linaro.org>
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
perror("failed to connect");
+ close(fd);
return false;
}
--
2.20.1
next prev parent reply other threads:[~2020-11-16 12:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 12:24 [PULL 0/9] various fixes (CI, Xen, warnings) Alex Bennée
2020-11-16 12:24 ` Alex Bennée [this message]
2020-11-16 12:24 ` [PULL 2/9] plugins: Fix two resource leaks in setup_socket() Alex Bennée
2020-11-16 12:24 ` [PULL 3/9] meson.build: fix building of Xen support for aarch64 Alex Bennée
2020-11-16 12:24 ` [PULL 4/9] include/hw/xen.h: drop superfluous struct Alex Bennée
2020-11-16 12:24 ` [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub Alex Bennée
2020-11-16 12:24 ` [PULL 6/9] accel/stubs: drop unused cpu.h include Alex Bennée
2020-11-16 12:24 ` [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Alex Bennée
2020-11-16 12:27 ` Michael S. Tsirkin
2020-11-16 13:11 ` Philippe Mathieu-Daudé
2020-11-16 13:27 ` Michael S. Tsirkin
2020-11-16 16:01 ` Alex Bennée
2020-11-16 12:24 ` [PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test Alex Bennée
2020-11-16 12:24 ` [PULL 9/9] .gitlab-ci.d/check-patch: tweak output for CI logs Alex Bennée
2020-11-16 17:00 ` [PULL 0/9] various fixes (CI, Xen, warnings) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116122417.28346-2-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alex.chen@huawei.com \
--cc=euler.robot@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).