Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

[Cornelia Huck]

On Fri, 13 Nov 2020 17:10:22 -0500
Collin Walling <walling@linux.ibm.com> wrote:

[please remember to put qemu-devel on cc: as well]

> The Control Program Name Code (CPNC) portion of the diag318
> info must be set within the SIE block of each VCPU in the
> configuration. The handler will iterate through each VCPU
> and dirty the diag318_info reg to be synced with KVM on a
> subsequent sync_regs call.
> 
> Additionally, the diag318 info resets must be handled via
> userspace. As such, QEMU will reset this value for each
> VCPU during a modified clear, load normal, and load clear
> reset event.
> 
> Fixes: fabdada9357b ("s390: guest support for diagnose 0x318")
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
> 
> Changelog:
> 
>         v3:
>         - moved loop outside of switch block
>         - added kvm_s390_set_diag318 function, called by
>             do_cpu_function (this is so other archs do
>             not complain)
> 
>         v2:
>         - added Fixes tag
>         - added CPU feat check in do_cpu function
> 
> ---
>  hw/s390x/s390-virtio-ccw.c |  4 ++++
>  target/s390x/cpu.c         |  7 +++++++
>  target/s390x/cpu.h         |  1 +
>  target/s390x/kvm-stub.c    |  4 ++++
>  target/s390x/kvm.c         | 22 +++++++++++++++++-----
>  target/s390x/kvm_s390x.h   |  1 +
>  6 files changed, 34 insertions(+), 5 deletions(-)

Thanks, queued to s390-fixes.

I plan to send a pull request tomorrow.

Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

[Collin Walling]

On 11/16/20 7:12 AM, Cornelia Huck wrote:
> On Fri, 13 Nov 2020 17:10:22 -0500
> Collin Walling <walling@linux.ibm.com> wrote:
> 
> [please remember to put qemu-devel on cc: as well]
> 
>> The Control Program Name Code (CPNC) portion of the diag318
>> info must be set within the SIE block of each VCPU in the
>> configuration. The handler will iterate through each VCPU
>> and dirty the diag318_info reg to be synced with KVM on a
>> subsequent sync_regs call.
>>
>> Additionally, the diag318 info resets must be handled via
>> userspace. As such, QEMU will reset this value for each
>> VCPU during a modified clear, load normal, and load clear
>> reset event.
>>
>> Fixes: fabdada9357b ("s390: guest support for diagnose 0x318")
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>> ---
>>
>> Changelog:
>>
>>         v3:
>>         - moved loop outside of switch block
>>         - added kvm_s390_set_diag318 function, called by
>>             do_cpu_function (this is so other archs do
>>             not complain)
>>
>>         v2:
>>         - added Fixes tag
>>         - added CPU feat check in do_cpu function
>>
>> ---
>>  hw/s390x/s390-virtio-ccw.c |  4 ++++
>>  target/s390x/cpu.c         |  7 +++++++
>>  target/s390x/cpu.h         |  1 +
>>  target/s390x/kvm-stub.c    |  4 ++++
>>  target/s390x/kvm.c         | 22 +++++++++++++++++-----
>>  target/s390x/kvm_s390x.h   |  1 +
>>  6 files changed, 34 insertions(+), 5 deletions(-)
> 
> Thanks, queued to s390-fixes.
> 
> I plan to send a pull request tomorrow.
> 
> 

Much appreciated.

-- 
Regards,
Collin

Stay safe and stay healthy