qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	alex.williamson@redhat.com
Cc: peter.maydell@linaro.org, jacob.jun.pan@linux.intel.com,
	jean-philippe@linaro.org, tn@semihalf.com,
	shameerali.kolothum.thodi@huawei.com, nicoleotsuka@gmail.com,
	vivek.gautam@arm.com, yi.l.liu@intel.com, peterx@redhat.com,
	zhangfei.gao@gmail.com, yuzenghui@huawei.com
Subject: [RFC v7 21/26] hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA invalidation
Date: Mon, 16 Nov 2020 19:13:44 +0100	[thread overview]
Message-ID: <20201116181349.11908-22-eric.auger@redhat.com> (raw)
In-Reply-To: <20201116181349.11908-1-eric.auger@redhat.com>

Let's propagate the leaf attribute throughout the invalidation path.
This hint is used to reduce the scope of the invalidations to the
last level of translation. Not enforcing it induces large performance
penalties in nested mode.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 hw/arm/smmuv3.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 553b785fda..c314f9e4c9 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -798,7 +798,7 @@ epilogue:
 static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
                                IOMMUNotifier *n,
                                int asid, dma_addr_t iova,
-                               uint8_t tg, uint64_t num_pages)
+                               uint8_t tg, uint64_t num_pages, bool leaf)
 {
     SMMUDevice *sdev = container_of(mr, SMMUDevice, iommu);
     IOMMUTLBEntry entry;
@@ -829,13 +829,13 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
     entry.addr_mask = num_pages * (1 << granule) - 1;
     entry.perm = IOMMU_NONE;
     entry.arch_id = asid;
+    entry.leaf = leaf;
 
     memory_region_notify_one(n, &entry);
 }
 
-/* invalidate an asid/iova range tuple in all mr's */
 static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, dma_addr_t iova,
-                                      uint8_t tg, uint64_t num_pages)
+                                      uint8_t tg, uint64_t num_pages, bool leaf)
 {
     SMMUDevice *sdev;
 
@@ -847,7 +847,7 @@ static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, dma_addr_t iova,
                                         tg, num_pages);
 
         IOMMU_NOTIFIER_FOREACH(n, mr) {
-            smmuv3_notify_iova(mr, n, asid, iova, tg, num_pages);
+            smmuv3_notify_iova(mr, n, asid, iova, tg, num_pages, leaf);
         }
     }
 }
@@ -874,7 +874,7 @@ static void smmuv3_s1_range_inval(SMMUState *s, Cmd *cmd)
         asid = CMD_ASID(cmd);
     }
     trace_smmuv3_s1_range_inval(vmid, asid, addr, tg, num_pages, ttl, leaf);
-    smmuv3_inv_notifiers_iova(s, asid, addr, tg, num_pages);
+    smmuv3_inv_notifiers_iova(s, asid, addr, tg, num_pages, leaf);
     smmu_iotlb_inv_iova(s, asid, addr, tg, num_pages, ttl);
 }
 
-- 
2.21.3



  parent reply	other threads:[~2020-11-16 18:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 18:13 [RFC v7 00/26] vSMMUv3/pSMMUv3 2 stage VFIO integration Eric Auger
2020-11-16 18:13 ` [RFC v7 01/26] update-linux-headers: Import iommu.h Eric Auger
2020-11-16 18:13 ` [RFC v7 02/26] header update against 5.10-rc4 and IOMMU/VFIO nested stage APIs Eric Auger
2020-11-16 18:13 ` [RFC v7 03/26] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute Eric Auger
2020-11-16 18:13 ` [RFC v7 04/26] memory: Add IOMMU_ATTR_MSI_TRANSLATE " Eric Auger
2020-11-16 18:13 ` [RFC v7 05/26] memory: Introduce IOMMU Memory Region inject_faults API Eric Auger
2020-11-16 18:13 ` [RFC v7 06/26] memory: Add arch_id and leaf fields in IOTLBEntry Eric Auger
2020-11-16 18:13 ` [RFC v7 07/26] iommu: Introduce generic header Eric Auger
2020-11-16 18:13 ` [RFC v7 08/26] pci: introduce PCIPASIDOps to PCIDevice Eric Auger
2020-11-16 18:13 ` [RFC v7 09/26] vfio: Force nested if iommu requires it Eric Auger
2020-11-16 18:13 ` [RFC v7 10/26] vfio: Introduce hostwin_from_range helper Eric Auger
2020-11-16 18:13 ` [RFC v7 11/26] vfio: Introduce helpers to DMA map/unmap a RAM section Eric Auger
2020-11-16 18:13 ` [RFC v7 12/26] vfio: Set up nested stage mappings Eric Auger
2020-12-24  8:42   ` Zenghui Yu
2020-11-16 18:13 ` [RFC v7 13/26] vfio: Pass stage 1 MSI bindings to the host Eric Auger
2020-11-16 18:13 ` [RFC v7 14/26] vfio: Helper to get IRQ info including capabilities Eric Auger
2020-11-16 18:13 ` [RFC v7 15/26] vfio/pci: Register handler for iommu fault Eric Auger
2020-11-16 18:13 ` [RFC v7 16/26] vfio/pci: Set up the DMA FAULT region Eric Auger
2020-11-16 18:13 ` [RFC v7 17/26] vfio/pci: Implement the DMA fault handler Eric Auger
2020-11-16 18:13 ` [RFC v7 18/26] hw/arm/smmuv3: Advertise MSI_TRANSLATE attribute Eric Auger
2020-11-16 18:13 ` [RFC v7 19/26] hw/arm/smmuv3: Store the PASID table GPA in the translation config Eric Auger
2020-11-16 18:13 ` [RFC v7 20/26] hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation Eric Auger
2020-11-16 18:13 ` Eric Auger [this message]
2020-11-16 18:13 ` [RFC v7 22/26] hw/arm/smmuv3: Pass stage 1 configurations to the host Eric Auger
2020-11-16 18:13 ` [RFC v7 23/26] hw/arm/smmuv3: Implement fault injection Eric Auger
2020-11-16 18:13 ` [RFC v7 24/26] hw/arm/smmuv3: Allow MAP notifiers Eric Auger
2020-11-16 18:13 ` [RFC v7 25/26] pci: Add return_page_response pci ops Eric Auger
2020-11-16 18:13 ` [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback Eric Auger
2021-02-18 10:19   ` Shameerali Kolothum Thodi
2021-02-18 10:41     ` Auger Eric
2021-02-18 11:46       ` Shameerali Kolothum Thodi
2021-02-18 13:32         ` Auger Eric
2021-02-24 13:43           ` Auger Eric
2021-02-24 15:38             ` Shameerali Kolothum Thodi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116181349.11908-22-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=jean-philippe@linaro.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=tn@semihalf.com \
    --cc=vivek.gautam@arm.com \
    --cc=yi.l.liu@intel.com \
    --cc=yuzenghui@huawei.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).