From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
alex.williamson@redhat.com
Cc: peter.maydell@linaro.org, jacob.jun.pan@linux.intel.com,
jean-philippe@linaro.org, tn@semihalf.com,
shameerali.kolothum.thodi@huawei.com, nicoleotsuka@gmail.com,
vivek.gautam@arm.com, yi.l.liu@intel.com, peterx@redhat.com,
zhangfei.gao@gmail.com, yuzenghui@huawei.com
Subject: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback
Date: Mon, 16 Nov 2020 19:13:49 +0100 [thread overview]
Message-ID: <20201116181349.11908-27-eric.auger@redhat.com> (raw)
In-Reply-To: <20201116181349.11908-1-eric.auger@redhat.com>
This patch implements the page response path. The
response s written into the page response ring buffer and then
update header's head index is updated. This path is not used
by this series. It is introduced here as a POC for vSVA/ARM
integration.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
hw/vfio/pci.h | 2 +
hw/vfio/pci.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 123 insertions(+)
diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
index 350e9e9005..ce0472611e 100644
--- a/hw/vfio/pci.h
+++ b/hw/vfio/pci.h
@@ -147,6 +147,8 @@ struct VFIOPCIDevice {
VFIOPCIExtIRQ *ext_irqs;
VFIORegion dma_fault_region;
uint32_t fault_tail_index;
+ VFIORegion dma_fault_response_region;
+ uint32_t fault_response_head_index;
int (*resetfn)(struct VFIOPCIDevice *);
uint32_t vendor_id;
uint32_t device_id;
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 4e3495bb60..797acd9c73 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2631,6 +2631,61 @@ out:
g_free(fault_region_info);
}
+static void vfio_init_fault_response_regions(VFIOPCIDevice *vdev, Error **errp)
+{
+ struct vfio_region_info *fault_region_info = NULL;
+ struct vfio_region_info_cap_fault *cap_fault;
+ VFIODevice *vbasedev = &vdev->vbasedev;
+ struct vfio_info_cap_header *hdr;
+ char *fault_region_name;
+ int ret;
+
+ ret = vfio_get_dev_region_info(&vdev->vbasedev,
+ VFIO_REGION_TYPE_NESTED,
+ VFIO_REGION_SUBTYPE_NESTED_DMA_FAULT_RESPONSE,
+ &fault_region_info);
+ if (ret) {
+ goto out;
+ }
+
+ hdr = vfio_get_region_info_cap(fault_region_info,
+ VFIO_REGION_INFO_CAP_DMA_FAULT);
+ if (!hdr) {
+ error_setg(errp, "failed to retrieve DMA FAULT RESPONSE capability");
+ goto out;
+ }
+ cap_fault = container_of(hdr, struct vfio_region_info_cap_fault,
+ header);
+ if (cap_fault->version != 1) {
+ error_setg(errp, "Unsupported DMA FAULT RESPONSE API version %d",
+ cap_fault->version);
+ goto out;
+ }
+
+ fault_region_name = g_strdup_printf("%s DMA FAULT RESPONSE %d",
+ vbasedev->name,
+ fault_region_info->index);
+
+ ret = vfio_region_setup(OBJECT(vdev), vbasedev,
+ &vdev->dma_fault_response_region,
+ fault_region_info->index,
+ fault_region_name);
+ g_free(fault_region_name);
+ if (ret) {
+ error_setg_errno(errp, -ret,
+ "failed to set up the DMA FAULT RESPONSE region %d",
+ fault_region_info->index);
+ goto out;
+ }
+
+ ret = vfio_region_mmap(&vdev->dma_fault_response_region);
+ if (ret) {
+ error_setg_errno(errp, -ret, "Failed to mmap the DMA FAULT RESPONSE queue");
+ }
+out:
+ g_free(fault_region_info);
+}
+
static void vfio_populate_device(VFIOPCIDevice *vdev, Error **errp)
{
VFIODevice *vbasedev = &vdev->vbasedev;
@@ -2706,6 +2761,12 @@ static void vfio_populate_device(VFIOPCIDevice *vdev, Error **errp)
return;
}
+ vfio_init_fault_response_regions(vdev, &err);
+ if (err) {
+ error_propagate(errp, err);
+ return;
+ }
+
irq_info.index = VFIO_PCI_ERR_IRQ_INDEX;
ret = ioctl(vdev->vbasedev.fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info);
@@ -2884,8 +2945,68 @@ static int vfio_iommu_set_pasid_table(PCIBus *bus, int32_t devfn,
return ioctl(container->fd, VFIO_IOMMU_SET_PASID_TABLE, &info);
}
+static int vfio_iommu_return_page_response(PCIBus *bus, int32_t devfn,
+ IOMMUPageResponse *resp)
+{
+ PCIDevice *pdev = bus->devices[devfn];
+ VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);
+ struct iommu_page_response *response = &resp->resp;
+ struct vfio_region_dma_fault_response header;
+ struct iommu_page_response *queue;
+ char *queue_buffer = NULL;
+ ssize_t bytes;
+
+ if (!vdev->dma_fault_response_region.mem) {
+ return -EINVAL;
+ }
+
+ /* read the header */
+ bytes = pread(vdev->vbasedev.fd, &header, sizeof(header),
+ vdev->dma_fault_response_region.fd_offset);
+ if (bytes != sizeof(header)) {
+ error_report("%s unable to read the fault region header (0x%lx)",
+ __func__, bytes);
+ return -1;
+ }
+
+ /* Normally the fault queue is mmapped */
+ queue = (struct iommu_page_response *)vdev->dma_fault_response_region.mmaps[0].mmap;
+ if (!queue) {
+ size_t queue_size = header.nb_entries * header.entry_size;
+
+ error_report("%s: fault queue not mmapped: slower fault handling",
+ vdev->vbasedev.name);
+
+ queue_buffer = g_malloc(queue_size);
+ bytes = pread(vdev->vbasedev.fd, queue_buffer, queue_size,
+ vdev->dma_fault_response_region.fd_offset + header.offset);
+ if (bytes != queue_size) {
+ error_report("%s unable to read the fault queue (0x%lx)",
+ __func__, bytes);
+ return -1;
+ }
+
+ queue = (struct iommu_page_response *)queue_buffer;
+ }
+ /* deposit the new response in the queue and increment the head */
+ memcpy(queue + header.head, response, header.entry_size);
+
+ vdev->fault_response_head_index =
+ (vdev->fault_response_head_index + 1) % header.nb_entries;
+ bytes = pwrite(vdev->vbasedev.fd, &vdev->fault_response_head_index, 4,
+ vdev->dma_fault_response_region.fd_offset);
+ if (bytes != 4) {
+ error_report("%s unable to write the fault response region head index (0x%lx)",
+ __func__, bytes);
+ }
+ g_free(queue_buffer);
+
+ return 0;
+}
+
static PCIPASIDOps vfio_pci_pasid_ops = {
.set_pasid_table = vfio_iommu_set_pasid_table,
+ .return_page_response = vfio_iommu_return_page_response,
};
static void vfio_dma_fault_notifier_handler(void *opaque)
--
2.21.3
next prev parent reply other threads:[~2020-11-16 18:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 18:13 [RFC v7 00/26] vSMMUv3/pSMMUv3 2 stage VFIO integration Eric Auger
2020-11-16 18:13 ` [RFC v7 01/26] update-linux-headers: Import iommu.h Eric Auger
2020-11-16 18:13 ` [RFC v7 02/26] header update against 5.10-rc4 and IOMMU/VFIO nested stage APIs Eric Auger
2020-11-16 18:13 ` [RFC v7 03/26] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute Eric Auger
2020-11-16 18:13 ` [RFC v7 04/26] memory: Add IOMMU_ATTR_MSI_TRANSLATE " Eric Auger
2020-11-16 18:13 ` [RFC v7 05/26] memory: Introduce IOMMU Memory Region inject_faults API Eric Auger
2020-11-16 18:13 ` [RFC v7 06/26] memory: Add arch_id and leaf fields in IOTLBEntry Eric Auger
2020-11-16 18:13 ` [RFC v7 07/26] iommu: Introduce generic header Eric Auger
2020-11-16 18:13 ` [RFC v7 08/26] pci: introduce PCIPASIDOps to PCIDevice Eric Auger
2020-11-16 18:13 ` [RFC v7 09/26] vfio: Force nested if iommu requires it Eric Auger
2020-11-16 18:13 ` [RFC v7 10/26] vfio: Introduce hostwin_from_range helper Eric Auger
2020-11-16 18:13 ` [RFC v7 11/26] vfio: Introduce helpers to DMA map/unmap a RAM section Eric Auger
2020-11-16 18:13 ` [RFC v7 12/26] vfio: Set up nested stage mappings Eric Auger
2020-12-24 8:42 ` Zenghui Yu
2020-11-16 18:13 ` [RFC v7 13/26] vfio: Pass stage 1 MSI bindings to the host Eric Auger
2020-11-16 18:13 ` [RFC v7 14/26] vfio: Helper to get IRQ info including capabilities Eric Auger
2020-11-16 18:13 ` [RFC v7 15/26] vfio/pci: Register handler for iommu fault Eric Auger
2020-11-16 18:13 ` [RFC v7 16/26] vfio/pci: Set up the DMA FAULT region Eric Auger
2020-11-16 18:13 ` [RFC v7 17/26] vfio/pci: Implement the DMA fault handler Eric Auger
2020-11-16 18:13 ` [RFC v7 18/26] hw/arm/smmuv3: Advertise MSI_TRANSLATE attribute Eric Auger
2020-11-16 18:13 ` [RFC v7 19/26] hw/arm/smmuv3: Store the PASID table GPA in the translation config Eric Auger
2020-11-16 18:13 ` [RFC v7 20/26] hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation Eric Auger
2020-11-16 18:13 ` [RFC v7 21/26] hw/arm/smmuv3: Fill the IOTLBEntry leaf field " Eric Auger
2020-11-16 18:13 ` [RFC v7 22/26] hw/arm/smmuv3: Pass stage 1 configurations to the host Eric Auger
2020-11-16 18:13 ` [RFC v7 23/26] hw/arm/smmuv3: Implement fault injection Eric Auger
2020-11-16 18:13 ` [RFC v7 24/26] hw/arm/smmuv3: Allow MAP notifiers Eric Auger
2020-11-16 18:13 ` [RFC v7 25/26] pci: Add return_page_response pci ops Eric Auger
2020-11-16 18:13 ` Eric Auger [this message]
2021-02-18 10:19 ` [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback Shameerali Kolothum Thodi
2021-02-18 10:41 ` Auger Eric
2021-02-18 11:46 ` Shameerali Kolothum Thodi
2021-02-18 13:32 ` Auger Eric
2021-02-24 13:43 ` Auger Eric
2021-02-24 15:38 ` Shameerali Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116181349.11908-27-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=nicoleotsuka@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tn@semihalf.com \
--cc=vivek.gautam@arm.com \
--cc=yi.l.liu@intel.com \
--cc=yuzenghui@huawei.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).