From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, stefanha@redhat.com
Subject: Re: [PULL 00/17] pc,vhost: fixes, new test
Date: Tue, 17 Nov 2020 04:20:56 -0500 [thread overview]
Message-ID: <20201117041924-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA9JdRPcEcKTqCHOMSeKpduy6jWS=kMa2sZCxa1BjGTzYg@mail.gmail.com>
On Mon, Nov 16, 2020 at 02:19:11PM +0000, Peter Maydell wrote:
> On Sun, 15 Nov 2020 at 22:27, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c:
> >
> > Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +0000)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to fe8d9946228d4df6c020f2cb38b6ac08981727cf:
> >
> > vhost-user-blk/scsi: Fix broken error handling for socket call (2020-11-15 17:05:47 -0500)
> >
> > ----------------------------------------------------------------
> > pc,vhost: fixes, new test
> >
> > Lots of fixes all over the place.
> > A new test case which seems like a good idea even at
> > this late stage: can't break things and will make
> > sure we don't introduce regressions.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
>
> Something in this seems to cause hangs in 'make check' on
> my x86-64 Linux box: sample 'ps wafux' output:
>
> petmay01 30354 0.0 0.0 17392 9348 ? S 13:40 0:00
> \_ make --output-sync -C build/a
> ll check V=1 -j8
> petmay01 7093 0.0 0.0 13916 3608 ? S 13:41 0:00
> \_ bash -o pipefail -c echo
> 'MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-i386 tests/qtest/qos-test --tap -k' &&
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-i386 tests/qtest/qos-test --tap -k <
> /dev/null | ./scripts/tap-driver.pl --test-name="qtest-i386/qos-test"
> petmay01 7095 0.0 0.0 37764 11744 ? S 13:41 0:00
> | \_ perl ./scripts/tap-driver.pl
> --test-name=qtest-i386/qos-test
> petmay01 14023 0.0 0.0 13916 3568 ? S 13:41 0:00
> \_ bash -o pipefail -c echo
> 'MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-ppc64 tests/qtest/qos-test --tap -k'
> && MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-ppc64 tests/qtest/qos-test --tap -k <
> /dev/null | ./scripts/tap-driver.pl --test-name="qtest-ppc64/qos-test"
> petmay01 14025 0.0 0.0 37828 11760 ? S 13:41 0:00
> | \_ perl ./scripts/tap-driver.pl
> --test-name=qtest-ppc64/qos-test
> petmay01 22886 0.0 0.0 13916 3716 ? S 13:42 0:00
> \_ bash -o pipefail -c echo
> 'MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test --tap -k'
> && MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test --tap -k <
> /dev/null | ./scripts/tap-driver.pl
> --test-name="qtest-x86_64/qos-test"
> petmay01 22888 0.0 0.0 37764 11836 ? S 13:42 0:00
> \_ perl ./scripts/tap-driver.pl
> --test-name=qtest-x86_64/qos-test
>
>
> Something somewhere is also apparently leaving a qemu-storage-daemon
> process running on bigendian hosts only (?): I see this on my s390x
> test box:
>
> ubuntu 26700 0.0 0.5 330776 21552 ? Sl 08:40 0:00
> ./storage-daemon/qemu-storage-daemon --chardev
> socket,id=qmp,fd=11,server,nowait --monitor chardev=qmp --blockdev
> driver=file,node-name=disk0,filename=qtest.V5gfPm --export
> type=vhost-user-blk,id=disk0,addr.type=fd,addr.str=16,node-name=disk0,writable=on,num-queues=8
> --blockdev driver=file,node-name=disk1,filename=qtest.JM24xB --export
> type=vhost-user-blk,id=disk1,addr.type=fd,addr.str=17,node-name=disk1,writable=on,num-queues=8
>
> and similarly on the ppc64be box (but not on other machines).
> This seems to be associated with this test failure:
>
> ERROR:../../tests/qtest/vhost-user-blk-test.c:738:multiqueue:
> assertion failed (num_queues == 8): (2048 == 8)
> ERROR qtest-i386/qos-test - Bail out!
> ERROR:../../tests/qtest/vhost-user-blk-test.c:738:multiqueue:
> assertion failed (num_queues == 8): (2048 == 8)
> Makefile.mtest:1857: recipe for target 'run-test-230' failed
>
> which looks suspiciously like an endianness bug somewhere.
>
> Ideally if the test case starts external processes it should
> make sure they're cleaned up even if the test fails.
>
> thanks
> -- PMM
Must be vhost user blk test patch exposing some more latent races ...
I dropped that for now, and sent pull v2.
Same tag.
--
MST
prev parent reply other threads:[~2020-11-17 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 22:27 [PULL 00/17] pc,vhost: fixes, new test Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 01/17] vhost-user: fix VHOST_USER_ADD/REM_MEM_REG truncation Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 02/17] meson: move vhost_user_blk_server to meson.build Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 03/17] vhost-user-blk-server: depend on CONFIG_VHOST_USER Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 04/17] configure: mark vhost-user Linux-only Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 05/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Michael S. Tsirkin
2020-11-16 17:44 ` Ani Sinha
2020-11-16 18:01 ` Philippe Mathieu-Daudé
2020-11-16 18:08 ` Ani Sinha
2020-11-15 22:27 ` [PULL 06/17] test: new qTest case to test the vhost-user-blk-server Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 07/17] tests/qtest: add multi-queue test case to vhost-user-blk-test Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 08/17] libqtest: add qtest_socket_server() Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 09/17] vhost-user-blk-test: rename destroy_drive() to destroy_file() Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 10/17] vhost-user-blk-test: close fork child file descriptors Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 11/17] vhost-user-blk-test: drop unused return value Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 12/17] vhost-user-blk-test: fix races by using fd passing Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 13/17] block/export: port virtio-blk discard/write zeroes input validation Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 14/17] vhost-user-blk-test: test discard/write zeroes invalid inputs Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 15/17] block/export: port virtio-blk read/write range check Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 16/17] contrib/libvhost-user: Fix bad printf format specifiers Michael S. Tsirkin
2020-11-15 22:27 ` [PULL 17/17] vhost-user-blk/scsi: Fix broken error handling for socket call Michael S. Tsirkin
2020-11-16 14:19 ` [PULL 00/17] pc,vhost: fixes, new test Peter Maydell
2020-11-17 9:20 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117041924-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).