From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted
Date: Tue, 17 Nov 2020 12:38:50 +0100 [thread overview]
Message-ID: <20201117113850.GA5306@merkur.fritz.box> (raw)
In-Reply-To: <20201113211718.261671-1-mreitz@redhat.com>
Am 13.11.2020 um 22:17 hat Max Reitz geschrieben:
> Hi,
>
> While reviewing Berto’s block-status/write-zeroes series for quorum, I
> wondered how quorum’s permission code handles rewrite-corrupted. It
> turns out it doesn’t, and so qemu with a read-only rewrite-corrupted
> quorum node simply crashes once there is a mismatch that leads to a
> rewrite.
>
> It looks to me like this bug has existed for quite some time, so I don’t
> think this series must go into 5.2. OTOH, it’s a simple bug fix, so I
> suppose it might as well.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2020-11-17 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 21:17 [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted Max Reitz
2020-11-13 21:17 ` [PATCH 1/3] " Max Reitz
2020-11-16 12:22 ` Alberto Garcia
2020-11-13 21:17 ` [PATCH 2/3] iotests/081: Filter image format after testdir Max Reitz
2020-11-13 21:17 ` [PATCH 3/3] iotests/081: Test rewrite-corrupted without WRITE Max Reitz
2020-11-17 11:38 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117113850.GA5306@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).