qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted
Date: Tue, 17 Nov 2020 13:15:56 +0100	[thread overview]
Message-ID: <20201117121558.249585-6-kwolf@redhat.com> (raw)
In-Reply-To: <20201117121558.249585-1-kwolf@redhat.com>

From: Max Reitz <mreitz@redhat.com>

Using rewrite-corrupted means quorum may issue writes to its children
just from receiving read requests from its parents.  Thus, it must take
the WRITE permission when rewrite-corrupted is used.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201113211718.261671-2-mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/quorum.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/block/quorum.c b/block/quorum.c
index e846a7e892..b10fc2089e 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1163,7 +1163,12 @@ static void quorum_child_perm(BlockDriverState *bs, BdrvChild *c,
                               uint64_t perm, uint64_t shared,
                               uint64_t *nperm, uint64_t *nshared)
 {
+    BDRVQuorumState *s = bs->opaque;
+
     *nperm = perm & DEFAULT_PERM_PASSTHROUGH;
+    if (s->rewrite_corrupted) {
+        *nperm |= BLK_PERM_WRITE;
+    }
 
     /*
      * We cannot share RESIZE or WRITE, as this would make the
-- 
2.28.0



  parent reply	other threads:[~2020-11-17 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 12:15 [PULL 0/7] Patches for 5.2.0-rc2 Kevin Wolf
2020-11-17 12:15 ` [PULL 1/7] char-stdio: Fix QMP default for 'signal' Kevin Wolf
2020-11-17 12:15 ` [PULL 2/7] iotests: Replace deprecated ConfigParser.readfp() Kevin Wolf
2020-11-17 12:15 ` [PULL 3/7] file-posix: allow -EBUSY errors during write zeros on raw block devices Kevin Wolf
2020-11-17 12:15 ` [PULL 4/7] io_uring: do not use pointer after free Kevin Wolf
2020-11-17 12:15 ` Kevin Wolf [this message]
2020-11-17 12:15 ` [PULL 6/7] iotests/081: Filter image format after testdir Kevin Wolf
2020-11-17 12:15 ` [PULL 7/7] iotests/081: Test rewrite-corrupted without WRITE Kevin Wolf
2020-11-17 16:40 ` [PULL 0/7] Patches for 5.2.0-rc2 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117121558.249585-6-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).