qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>
Subject: [PATCH  v1 2/6] tests: add prefixes to the bare mkdtemp calls
Date: Tue, 17 Nov 2020 17:36:31 +0000	[thread overview]
Message-ID: <20201117173635.29101-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201117173635.29101-1-alex.bennee@linaro.org>

The first step to debug a thing is to know what created the thing in
the first place. Add some prefixes so random tmpdir's have something
grep in the code.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - fix long lines
---
 python/qemu/machine.py                    | 3 ++-
 tests/acceptance/avocado_qemu/__init__.py | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 6420f01bed..64d966aeeb 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -303,7 +303,8 @@ class QEMUMachine:
         return args
 
     def _pre_launch(self) -> None:
-        self._temp_dir = tempfile.mkdtemp(dir=self._test_dir)
+        self._temp_dir = tempfile.mkdtemp(prefix="qemu-machine-",
+                                          dir=self._test_dir)
         self._qemu_log_path = os.path.join(self._temp_dir, self._name + ".log")
         self._qemu_log_file = open(self._qemu_log_path, 'wb')
 
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 4cda037187..3033b2cabe 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -171,7 +171,8 @@ class Test(avocado.Test):
             self.cancel("No QEMU binary defined or found in the build tree")
 
     def _new_vm(self, *args):
-        vm = QEMUMachine(self.qemu_bin, sock_dir=tempfile.mkdtemp())
+        sd = tempfile.mkdtemp(prefix="avocado_qemu_sock_")
+        vm = QEMUMachine(self.qemu_bin, sock_dir=sd)
         if args:
             vm.add_args(*args)
         return vm
-- 
2.20.1



  parent reply	other threads:[~2020-11-17 17:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 17:36 [PATCH for 5.3-rc3 v1 0/6] testing fixes (avocado, gitlab) Alex Bennée
2020-11-17 17:36 ` [PATCH v1 1/6] scripts/ci: clean up default args logic a little Alex Bennée
2020-11-20 20:42   ` Wainer dos Santos Moschetta
2020-11-17 17:36 ` Alex Bennée [this message]
2020-11-17 17:56   ` [PATCH v1 2/6] tests: add prefixes to the bare mkdtemp calls Philippe Mathieu-Daudé
2020-11-18  9:44   ` Thomas Huth
2020-11-20 18:55   ` Wainer dos Santos Moschetta
2020-11-17 17:36 ` [PATCH v1 3/6] tests/avocado: clean-up socket directory after run Alex Bennée
2020-11-20 18:59   ` Wainer dos Santos Moschetta
2020-11-23  9:23     ` Alex Bennée
2020-11-23 13:43       ` Wainer dos Santos Moschetta
2020-11-17 17:36 ` [PATCH v1 4/6] gitlab: move remaining x86 check-tcg targets to gitlab Alex Bennée
2020-11-18  9:51   ` Thomas Huth
2020-11-20 17:45   ` Wainer dos Santos Moschetta
2020-11-17 17:36 ` [PATCH v1 5/6] tests/docker: Install liblttng-ust-dev package in Ubuntu 20.04 image Alex Bennée
2020-11-17 17:36 ` [PATCH v1 6/6] gitlab-ci: Move trace backend tests across to gitlab Alex Bennée
2020-11-18  9:54   ` Thomas Huth
2020-11-20 14:35     ` Thomas Huth
2020-11-19 14:40 ` [PATCH for 5.2-rc3 v1 0/6] testing fixes (avocado, gitlab) Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117173635.29101-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).