qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: "Venegas Munoz, Jose Carlos" <jose.carlos.venegas.munoz@intel.com>
Cc: virtio-fs-list <virtio-fs@redhat.com>,
	Miklos Szeredi <mszeredi@redhat.com>,
	"Shinde, Archana M" <archana.m.shinde@intel.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool
Date: Tue, 17 Nov 2020 17:24:50 -0500	[thread overview]
Message-ID: <20201117222450.GC91497@redhat.com> (raw)
In-Reply-To: <C5CAD300-DB1D-4C6A-A2D3-2E6BA9F901DF@intel.com>

On Tue, Nov 17, 2020 at 04:00:09PM +0000, Venegas Munoz, Jose Carlos wrote:
> >   Not sure what the default is for 9p, but comparing
> >   default to default will definitely not be apples to apples since this
> >   mode is nonexistent in 9p.
> 
> In Kata we are looking for the best config for fs compatibility and performance. So even if are no apples to apples,
> we are for the best config for both and comparing the best that each of them can do.

Can we run tests in more than one configuration. Right now you are using
cache=mmap for virtio-9p and cache=auto for virtiofs and as Miklos
said this is not apples to apples comparison.

So you can continue to run above but also run additional tests if
time permits.

virtio-9p	virtio-fs

cache=mmap	cache=none + DAX
cache=none	cache=none
cache=loose	cache=always

Given you are using cache=mmap for virtio-9p, "cache=none + DAX" is
somewhat equivalent of that. Provides strong coherency as well as
allow for mmap() to work.

Now kernel virtiofs DAX support got merged in 5.10-rc1. For qemu,
you can use virtio-fs-dev branch.

https://gitlab.com/virtio-fs/qemu/-/commits/virtio-fs-dev

Thanks
Vivek



  parent reply	other threads:[~2020-11-17 22:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 19:44 [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool Vivek Goyal
2020-11-05 19:52 ` [Virtio-fs] " Vivek Goyal
2020-11-06 20:33   ` Venegas Munoz, Jose Carlos
2020-11-06 22:35     ` Vivek Goyal
2020-11-09 10:02       ` Dr. David Alan Gilbert
2020-11-09 14:39         ` Vivek Goyal
2020-11-12  9:06       ` Miklos Szeredi
2020-11-12  9:57         ` Miklos Szeredi
2020-11-18 20:19           ` Vivek Goyal
2020-11-12 11:00         ` Christian Schoenebeck
2020-11-12 13:01           ` Miklos Szeredi
2020-11-17 16:00         ` Venegas Munoz, Jose Carlos
2020-11-17 16:39           ` Christian Schoenebeck
2020-11-17 18:55           ` Vivek Goyal
2020-11-23 15:06             ` Venegas Munoz, Jose Carlos
2020-11-17 22:24           ` Vivek Goyal [this message]
2020-11-23 15:07             ` Venegas Munoz, Jose Carlos
2020-11-18 19:51         ` Vivek Goyal
2020-11-23  9:46           ` Miklos Szeredi
2020-11-09 10:11 ` Dr. David Alan Gilbert
2020-11-09 14:40   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117222450.GC91497@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=archana.m.shinde@intel.com \
    --cc=jose.carlos.venegas.munoz@intel.com \
    --cc=miklos@szeredi.hu \
    --cc=mszeredi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).