From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 1/7] meson: Fix argument for makensis (build regression)
Date: Wed, 18 Nov 2020 11:19:34 +0100 [thread overview]
Message-ID: <20201118101940.132594-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20201118101940.132594-1-pbonzini@redhat.com>
From: Stefan Weil <sw@weilnetz.de>
`make installer` with a DLL directory was broken.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20201117190640.390359-1-sw@weilnetz.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/nsis.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/nsis.py b/scripts/nsis.py
index e1c409344e..5135a05831 100644
--- a/scripts/nsis.py
+++ b/scripts/nsis.py
@@ -65,7 +65,7 @@ def main():
dlldir = "w64"
makensis += ["-DW64"]
if os.path.exists(os.path.join(args.srcdir, "dll")):
- makensis += "-DDLLDIR={0}/dll/{1}".format(args.srcdir, dlldir)
+ makensis += ["-DDLLDIR={0}/dll/{1}".format(args.srcdir, dlldir)]
makensis += ["-DOUTFILE=" + args.outfile] + args.nsisargs
subprocess.run(makensis)
--
2.28.0
next prev parent reply other threads:[~2020-11-18 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:19 [PULL 0/7] HVF and Windows changes for QEMU 5.2-rc Paolo Bonzini
2020-11-18 10:19 ` Paolo Bonzini [this message]
2020-11-18 10:19 ` [PULL 2/7] docs: Fix some typos (found by codespell) Paolo Bonzini
2020-11-18 10:19 ` [PULL 3/7] meson: Fix build with --disable-guest-agent-msi Paolo Bonzini
2020-11-18 10:19 ` [PULL 4/7] meson: Fixes curses detection on msys2 Paolo Bonzini
2020-11-18 10:19 ` [PULL 5/7] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET Paolo Bonzini
2020-11-18 10:19 ` [PULL 6/7] hvf: Fix segment selector format Paolo Bonzini
2020-11-18 10:19 ` [PULL 7/7] buildsys: Help git-diff adding .gitattributes config file Paolo Bonzini
2020-11-18 13:42 ` [PULL 0/7] HVF and Windows changes for QEMU 5.2-rc Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118101940.132594-2-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).