* [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET
@ 2020-11-16 20:03 Jessica Clarke
2020-11-17 8:42 ` Paolo Bonzini
2020-11-18 17:08 ` Roman Bolshakov
0 siblings, 2 replies; 3+ messages in thread
From: Jessica Clarke @ 2020-11-16 20:03 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Richard Henderson, Cameron Esfahani,
Roman Bolshakov, Paolo Bonzini, Jessica Clarke
Buglink: https://bugs.launchpad.net/qemu/+bug/1894836
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
---
target/i386/hvf/x86_cpuid.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c
index 16762b6eb4..fc1f87ec57 100644
--- a/target/i386/hvf/x86_cpuid.c
+++ b/target/i386/hvf/x86_cpuid.c
@@ -122,6 +122,10 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx,
CPUID_PAT | CPUID_PSE36 | CPUID_EXT2_MMXEXT | CPUID_MMX |
CPUID_FXSR | CPUID_EXT2_FXSR | CPUID_EXT2_PDPE1GB | CPUID_EXT2_3DNOWEXT |
CPUID_EXT2_3DNOW | CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX;
+ hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap);
+ if (!(cap & CPU_BASED2_RDTSCP)) {
+ edx &= ~CPUID_EXT2_RDTSCP;
+ }
hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cap);
if (!(cap & CPU_BASED_TSC_OFFSET)) {
edx &= ~CPUID_EXT2_RDTSCP;
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET
2020-11-16 20:03 [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET Jessica Clarke
@ 2020-11-17 8:42 ` Paolo Bonzini
2020-11-18 17:08 ` Roman Bolshakov
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-11-17 8:42 UTC (permalink / raw)
To: Jessica Clarke, qemu-devel
Cc: Roman Bolshakov, Richard Henderson, Eduardo Habkost,
Cameron Esfahani
On 16/11/20 21:03, Jessica Clarke wrote:
> Buglink: https://bugs.launchpad.net/qemu/+bug/1894836
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
> ---
> target/i386/hvf/x86_cpuid.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c
> index 16762b6eb4..fc1f87ec57 100644
> --- a/target/i386/hvf/x86_cpuid.c
> +++ b/target/i386/hvf/x86_cpuid.c
> @@ -122,6 +122,10 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx,
> CPUID_PAT | CPUID_PSE36 | CPUID_EXT2_MMXEXT | CPUID_MMX |
> CPUID_FXSR | CPUID_EXT2_FXSR | CPUID_EXT2_PDPE1GB | CPUID_EXT2_3DNOWEXT |
> CPUID_EXT2_3DNOW | CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX;
> + hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap);
> + if (!(cap & CPU_BASED2_RDTSCP)) {
> + edx &= ~CPUID_EXT2_RDTSCP;
> + }
> hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cap);
> if (!(cap & CPU_BASED_TSC_OFFSET)) {
> edx &= ~CPUID_EXT2_RDTSCP;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET
2020-11-16 20:03 [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET Jessica Clarke
2020-11-17 8:42 ` Paolo Bonzini
@ 2020-11-18 17:08 ` Roman Bolshakov
1 sibling, 0 replies; 3+ messages in thread
From: Roman Bolshakov @ 2020-11-18 17:08 UTC (permalink / raw)
To: Jessica Clarke
Cc: Paolo Bonzini, Richard Henderson, qemu-devel, Cameron Esfahani,
Eduardo Habkost
On Mon, Nov 16, 2020 at 08:03:19PM +0000, Jessica Clarke wrote:
> Buglink: https://bugs.launchpad.net/qemu/+bug/1894836
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
> ---
> target/i386/hvf/x86_cpuid.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c
> index 16762b6eb4..fc1f87ec57 100644
> --- a/target/i386/hvf/x86_cpuid.c
> +++ b/target/i386/hvf/x86_cpuid.c
> @@ -122,6 +122,10 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx,
> CPUID_PAT | CPUID_PSE36 | CPUID_EXT2_MMXEXT | CPUID_MMX |
> CPUID_FXSR | CPUID_EXT2_FXSR | CPUID_EXT2_PDPE1GB | CPUID_EXT2_3DNOWEXT |
> CPUID_EXT2_3DNOW | CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX;
> + hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap);
> + if (!(cap & CPU_BASED2_RDTSCP)) {
> + edx &= ~CPUID_EXT2_RDTSCP;
> + }
> hv_vmx_read_capability(HV_VMX_CAP_PROCBASED, &cap);
> if (!(cap & CPU_BASED_TSC_OFFSET)) {
> edx &= ~CPUID_EXT2_RDTSCP;
> --
> 2.28.0
>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Thanks,
Roman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-18 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 20:03 [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET Jessica Clarke
2020-11-17 8:42 ` Paolo Bonzini
2020-11-18 17:08 ` Roman Bolshakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).