qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 3/4] meson: move qxl trace events to separate file
Date: Thu, 19 Nov 2020 09:33:07 +0000	[thread overview]
Message-ID: <20201119093307.GC579364@redhat.com> (raw)
In-Reply-To: <20201119084448.24397-4-kraxel@redhat.com>

On Thu, Nov 19, 2020 at 09:44:47AM +0100, Gerd Hoffmann wrote:
> Move qxl trace events to separate trace-events-qxl file.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/qxl-render.c     |  1 +
>  hw/display/qxl.c            |  1 +
>  hw/display/meson.build      |  4 +++
>  hw/display/trace-events     | 67 -------------------------------------
>  hw/display/trace-events-qxl | 66 ++++++++++++++++++++++++++++++++++++

FWIW, I think we should name the files to match the source prefix,
such as  'qxl.trace-events', so that a simple glob  hw/display/qxl*
will match everything for the MAINTAINERS file assignments.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-11-19  9:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  8:44 [PATCH 0/4] [RfC] try fix tracing for modules Gerd Hoffmann
2020-11-19  8:44 ` [PATCH 1/4] meson: add trace_events_config[] Gerd Hoffmann
2020-11-19  9:50   ` Stefan Hajnoczi
2020-11-19  8:44 ` [PATCH 2/4] meson: move up hw subdir (specifically before trace subdir) Gerd Hoffmann
2020-11-19 10:01   ` Stefan Hajnoczi
2020-11-19  8:44 ` [PATCH 3/4] meson: move qxl trace events to separate file Gerd Hoffmann
2020-11-19  9:33   ` Daniel P. Berrangé [this message]
2020-11-19 10:06   ` Stefan Hajnoczi
2020-11-19 10:25     ` Gerd Hoffmann
2020-11-19  8:44 ` [PATCH 4/4] [broken] meson: try link tracepoints to module Gerd Hoffmann
2020-11-19 11:03   ` Stefan Hajnoczi
2020-11-19 11:23     ` Gerd Hoffmann
2020-11-19 11:55       ` Stefan Hajnoczi
2020-11-20 10:23         ` Gerd Hoffmann
2020-11-20 11:25           ` Gerd Hoffmann
2020-11-20 12:30             ` Philippe Mathieu-Daudé
2020-11-20 13:06               ` Paolo Bonzini
2020-11-20 13:15               ` Gerd Hoffmann
2020-11-20 13:05             ` Paolo Bonzini
2020-11-23 11:38               ` Gerd Hoffmann
2020-11-23 13:16                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119093307.GC579364@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).