From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] [broken] meson: try link tracepoints to module
Date: Thu, 19 Nov 2020 12:23:23 +0100 [thread overview]
Message-ID: <20201119112323.3rcfmee2jm3uw3ym@sirius.home.kraxel.org> (raw)
In-Reply-To: <20201119110316.GG701869@stefanha-x1.localdomain>
Hi,
> > diff --git a/trace/meson.build b/trace/meson.build
> > index 66395d3e2ba7..3f0fe7b7b74c 100644
> > --- a/trace/meson.build
> > +++ b/trace/meson.build
> > @@ -18,6 +18,7 @@ foreach c : trace_events_config
> > trace_events_files += [ trace_events_file ]
> > group = '--group=' + c.get('group')
> > fmt = '@0@-' + c.get('group') + '.@1@'
> > + module_ss = c.get('ss', trace_ss)
>
> One idea: module_ss is already used in other files. Are you sure there
> isn't an identifier naming conflict?
Nope. Tried s/module_ss/kraxel_ss/, still not working.
I get tons of "undefined reference to `_TRACE_something'"
errors (*not* qxl). Seems trace_ss is not updated as intended.
take care,
Gerd
next prev parent reply other threads:[~2020-11-19 11:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 8:44 [PATCH 0/4] [RfC] try fix tracing for modules Gerd Hoffmann
2020-11-19 8:44 ` [PATCH 1/4] meson: add trace_events_config[] Gerd Hoffmann
2020-11-19 9:50 ` Stefan Hajnoczi
2020-11-19 8:44 ` [PATCH 2/4] meson: move up hw subdir (specifically before trace subdir) Gerd Hoffmann
2020-11-19 10:01 ` Stefan Hajnoczi
2020-11-19 8:44 ` [PATCH 3/4] meson: move qxl trace events to separate file Gerd Hoffmann
2020-11-19 9:33 ` Daniel P. Berrangé
2020-11-19 10:06 ` Stefan Hajnoczi
2020-11-19 10:25 ` Gerd Hoffmann
2020-11-19 8:44 ` [PATCH 4/4] [broken] meson: try link tracepoints to module Gerd Hoffmann
2020-11-19 11:03 ` Stefan Hajnoczi
2020-11-19 11:23 ` Gerd Hoffmann [this message]
2020-11-19 11:55 ` Stefan Hajnoczi
2020-11-20 10:23 ` Gerd Hoffmann
2020-11-20 11:25 ` Gerd Hoffmann
2020-11-20 12:30 ` Philippe Mathieu-Daudé
2020-11-20 13:06 ` Paolo Bonzini
2020-11-20 13:15 ` Gerd Hoffmann
2020-11-20 13:05 ` Paolo Bonzini
2020-11-23 11:38 ` Gerd Hoffmann
2020-11-23 13:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119112323.3rcfmee2jm3uw3ym@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).