Re: [PATCH 4/4] [broken] meson: try link tracepoints to module

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Thu, Nov 19, 2020 at 12:23:23PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > diff --git a/trace/meson.build b/trace/meson.build
> > > index 66395d3e2ba7..3f0fe7b7b74c 100644
> > > --- a/trace/meson.build
> > > +++ b/trace/meson.build
> > > @@ -18,6 +18,7 @@ foreach c : trace_events_config
> > >    trace_events_files += [ trace_events_file ]
> > >    group = '--group=' + c.get('group')
> > >    fmt = '@0@-' + c.get('group') + '.@1@'
> > > +  module_ss = c.get('ss', trace_ss)
> > 
> > One idea: module_ss is already used in other files. Are you sure there
> > isn't an identifier naming conflict?
> 
> Nope.  Tried s/module_ss/kraxel_ss/, still not working.
> 
> I get tons of "undefined reference to `_TRACE_something'"
> errors (*not* qxl).  Seems trace_ss is not updated as intended.

Okay. There is a workaround available:
[PATCH v2] trace: use STAP_SDT_V2 to work around symbol visibility

We can take time to figure out how to extend the build system to handle
modules.

Would you like me to try to debug this?

I'm also on #qemu IRC if you want to discuss.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]