qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, crosa@redhat.com, ehabkost@redhat.com,
	vsementsov@virtuozzo.com, eblake@redhat.com, jsnow@redhat.com,
	armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	den@openvz.org, andrey.shinkevich@virtuozzo.com
Subject: [PATCH 1/4] block: bdrv_get_xdbg_block_graph() drop unused errp argument
Date: Thu, 19 Nov 2020 16:16:31 +0300	[thread overview]
Message-ID: <20201119131634.14009-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20201119131634.14009-1-vsementsov@virtuozzo.com>

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/block/block.h | 2 +-
 block.c               | 2 +-
 blockdev.c            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/block/block.h b/include/block/block.h
index c9d7c58765..d17151abd7 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -524,7 +524,7 @@ void bdrv_eject(BlockDriverState *bs, bool eject_flag);
 const char *bdrv_get_format_name(BlockDriverState *bs);
 BlockDriverState *bdrv_find_node(const char *node_name);
 BlockDeviceInfoList *bdrv_named_nodes_list(bool flat, Error **errp);
-XDbgBlockGraph *bdrv_get_xdbg_block_graph(Error **errp);
+XDbgBlockGraph *bdrv_get_xdbg_block_graph(void);
 BlockDriverState *bdrv_lookup_bs(const char *device,
                                  const char *node_name,
                                  Error **errp);
diff --git a/block.c b/block.c
index f1cedac362..eca16a5e29 100644
--- a/block.c
+++ b/block.c
@@ -5338,7 +5338,7 @@ static void xdbg_graph_add_edge(XDbgBlockGraphConstructor *gr, void *parent,
 }
 
 
-XDbgBlockGraph *bdrv_get_xdbg_block_graph(Error **errp)
+XDbgBlockGraph *bdrv_get_xdbg_block_graph(void)
 {
     BlockBackend *blk;
     BlockJob *job;
diff --git a/blockdev.c b/blockdev.c
index fe6fb5dc1d..6f103e5ce7 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2911,7 +2911,7 @@ BlockDeviceInfoList *qmp_query_named_block_nodes(bool has_flat,
 
 XDbgBlockGraph *qmp_x_debug_query_block_graph(Error **errp)
 {
-    return bdrv_get_xdbg_block_graph(errp);
+    return bdrv_get_xdbg_block_graph();
 }
 
 void qmp_blockdev_backup(BlockdevBackup *backup, Error **errp)
-- 
2.21.3



  reply	other threads:[~2020-11-19 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 13:16 [PATCH 0/4] Add function to dump block layer for debugging Vladimir Sementsov-Ogievskiy
2020-11-19 13:16 ` Vladimir Sementsov-Ogievskiy [this message]
2020-11-19 13:16 ` [PATCH 2/4] blockjob: add block_jobs_info_list() Vladimir Sementsov-Ogievskiy
2020-11-19 13:16 ` [PATCH 3/4] block: add dbg_dump_block_layer() Vladimir Sementsov-Ogievskiy
2020-11-19 17:02   ` Eric Blake
2020-11-19 13:16 ` [PATCH 4/4] scripts/render_block_graph.py: add ability to parse json files Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119131634.14009-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).