qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>
Cc: Jason Herne <jjherne@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	qemu-devel@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org
Subject: [PATCH v2 0/2] pc-bios/s390 fixes for reboot-to-vfio-ccw
Date: Fri, 20 Nov 2020 17:01:15 +0100	[thread overview]
Message-ID: <20201120160117.59366-1-farman@linux.ibm.com> (raw)

Thomas, Conny,

Here is the updated series for the re-IPL fixes mentioned yesterday [1]

I've updated the reviews/acks to Patch 1 (Thank you Conny, Janosch!),
and implemented Thomas' suggestion to clear out the memory where S390EP
exists early in our processing. This both preserves the delicate balance
we have today, and fixes the scenario I've been wrestling with.

For this second patch, I opted to #define the address x10008 and use it
in both the new memset and existing memcmp, rather than having the
address used directly in two places. I put this definition in s390-arch.h
as it's shared by both files, even though it's not strictly an
"s390 architecture" thing. Considering its importance, it seems like a
reasonable fit.

Tested with my permutations of virtio/vfio/chreipl/install things,
but surely missing some others that I don't have readily configured.

[1] https://lore.kernel.org/qemu-devel/20201119165729.63351-1-farman@linux.ibm.com/

Eric Farman (2):
  pc-bios: s390x: Ensure Read IPL memory is clean
  pc-bios: s390x: Clear out leftover S390EP string

 pc-bios/s390-ccw/dasd-ipl.c  | 3 +++
 pc-bios/s390-ccw/jump2ipl.c  | 2 +-
 pc-bios/s390-ccw/main.c      | 6 ++++++
 pc-bios/s390-ccw/s390-arch.h | 3 +++
 4 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.17.1



             reply	other threads:[~2020-11-20 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 16:01 Eric Farman [this message]
2020-11-20 16:01 ` [PATCH v2 1/2] pc-bios: s390x: Ensure Read IPL memory is clean Eric Farman
2020-11-20 16:01 ` [PATCH v2 2/2] pc-bios: s390x: Clear out leftover S390EP string Eric Farman
2020-11-23  7:39   ` Christian Borntraeger
2020-11-23  8:05     ` Thomas Huth
2020-11-23  8:07       ` Christian Borntraeger
2020-11-23  8:12         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120160117.59366-1-farman@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).