From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes
Date: Tue, 24 Nov 2020 12:03:05 +0100 [thread overview]
Message-ID: <20201124120305.1957dfe6.cohuck@redhat.com> (raw)
In-Reply-To: <20201118090344.243117-1-thuth@redhat.com>
On Wed, 18 Nov 2020 10:03:44 +0100
Thomas Huth <thuth@redhat.com> wrote:
> Both headers, sysbus.h and module.h, are not required to compile this file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/watchdog/wdt_diag288.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c
> index 71a945f0bd..4c4b6a6ab7 100644
> --- a/hw/watchdog/wdt_diag288.c
> +++ b/hw/watchdog/wdt_diag288.c
> @@ -14,12 +14,10 @@
> #include "qemu/osdep.h"
> #include "sysemu/reset.h"
> #include "sysemu/watchdog.h"
> -#include "hw/sysbus.h"
> #include "qemu/timer.h"
> #include "hw/watchdog/wdt_diag288.h"
> #include "migration/vmstate.h"
> #include "qemu/log.h"
> -#include "qemu/module.h"
>
> static WatchdogTimerModel model = {
> .wdt_name = TYPE_WDT_DIAG288,
Thanks, applied.
prev parent reply other threads:[~2020-11-24 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 9:03 [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes Thomas Huth
2020-11-18 9:06 ` Christian Borntraeger
2020-11-18 11:06 ` Philippe Mathieu-Daudé
2020-11-18 14:22 ` Markus Armbruster
2020-11-18 14:30 ` Peter Maydell
2020-11-23 8:16 ` Thomas Huth
2020-11-23 10:47 ` Markus Armbruster
2020-11-23 15:59 ` Cornelia Huck
2020-11-23 18:41 ` Thomas Huth
2020-11-24 11:02 ` Cornelia Huck
2020-11-24 11:03 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124120305.1957dfe6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).