qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Antoine Damhet <antoine.damhet@blade-group.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set.
Date: Wed, 25 Nov 2020 13:32:51 +0000	[thread overview]
Message-ID: <20201125133251.GI30079@redhat.com> (raw)
In-Reply-To: <20201125132711.jqb7znxu5jpoanwi@tartarus>

On Wed, Nov 25, 2020 at 02:27:11PM +0100, Antoine Damhet wrote:
> Hello,
> 
> We recently found out that some softwares are effectively crashing
> when they detect qemu's `OEM ID` or `OEM table ID` in the ACPI tables.
> 
> I see no reason not to expose the setting to the user/command-line. A
> previous patch has been submitted in 2015[1] but did not get through
> because (if I understand correctly) using the IDs on the `SLIC`, `BXPC`
> and `RSDT` tables were enough at the time.
> 
> If you agree, I am willing to forward port the patches of M. Jones but I
> need to ask how it would work `Signed-Off`-wise ?

On this point, the patch I sent was actually written by
Michael Tokarev, I was only trying to get them upstream.

Rich.

> Thanks in advance for your time,
> 
> PS: the softwares will crash if the signature is found in any of the
>     exposed tables.
> 
> [1]: https://lore.kernel.org/qemu-devel/1441220618-4750-1-git-send-email-rjones@redhat.com/
> 
> -- 
> Antoine 'xdbob' Damhet

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v



  reply	other threads:[~2020-11-25 13:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 13:27 [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set Antoine Damhet
2020-11-25 13:32 ` Richard W.M. Jones [this message]
2020-11-25 16:04   ` Michael S. Tsirkin
2020-11-25 20:13     ` Antoine Damhet
2020-11-26 11:09       ` Michael S. Tsirkin
2020-11-26 12:50         ` Antoine Damhet
2020-11-26 13:29           ` Michael S. Tsirkin
2020-11-26 16:34             ` Antoine Damhet
2020-11-26 17:05               ` Michael S. Tsirkin
2020-11-26 19:41                 ` Igor Mammedov
2020-11-26 17:09               ` Michael S. Tsirkin
2020-11-26 17:37                 ` Antoine Damhet
2020-11-26 12:51         ` Laszlo Ersek
2020-11-26 13:25           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125133251.GI30079@redhat.com \
    --to=rjones@redhat.com \
    --cc=antoine.damhet@blade-group.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).