From: Alex Chen <alex.chen@huawei.com>
To: <groug@kaod.org>, <qemu_oss@crudebyte.com>
Cc: alex.chen@huawei.com, qemu-trivial@nongnu.org,
qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()
Date: Thu, 26 Nov 2020 10:16:24 +0000 [thread overview]
Message-ID: <20201126101624.55714-1-alex.chen@huawei.com> (raw)
Only one of the options -s and -f can be used. When -f is used,
the fd is created externally and does not need to be closed.
When -s is used, a new socket fd is created, and this socket fd
needs to be closed at the end of main().
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
---
fsdev/virtfs-proxy-helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 15c0e79b06..339d477169 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -1154,6 +1154,9 @@ int main(int argc, char **argv)
process_requests(sock);
error:
g_free(rpath);
+ if (sock_name) {
+ close(sock);
+ }
g_free(sock_name);
do_log(LOG_INFO, "Done\n");
closelog();
--
2.19.1
next reply other threads:[~2020-11-26 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 10:16 Alex Chen [this message]
2020-11-26 10:50 ` [PATCH] virtfs-proxy-helper: Fix a resource leak in main() Li Qiang
2020-11-26 11:40 ` Alex Chen
2020-11-26 15:04 ` Li Qiang
2020-11-26 12:07 ` Greg Kurz
2020-11-26 13:15 ` Alex Chen
2020-11-26 17:52 ` Christian Schoenebeck
2020-11-26 18:27 ` Greg Kurz
2020-11-26 18:44 ` Christian Schoenebeck
2020-11-27 9:10 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126101624.55714-1-alex.chen@huawei.com \
--to=alex.chen@huawei.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).