From: Alex Chen <alex.chen@huawei.com>
To: <peter.maydell@linaro.org>, <jcd@tribudubois.net>,
<peter.chubb@nicta.com.au>
Cc: alex.chen@huawei.com, qemu-trivial@nongnu.org,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
zhang.zhanghailiang@huawei.com
Subject: [PATCH 5/5] misc/omap_sdrc: Fix bad printf format specifiers
Date: Thu, 26 Nov 2020 11:11:09 +0000 [thread overview]
Message-ID: <20201126111109.112238-6-alex.chen@huawei.com> (raw)
In-Reply-To: <20201126111109.112238-1-alex.chen@huawei.com>
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
---
hw/misc/omap_sdrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/omap_sdrc.c b/hw/misc/omap_sdrc.c
index f2f72f6810..c142fe0882 100644
--- a/hw/misc/omap_sdrc.c
+++ b/hw/misc/omap_sdrc.c
@@ -107,7 +107,7 @@ static void omap_sdrc_write(void *opaque, hwaddr addr,
case 0x10: /* SDRC_SYSCONFIG */
if ((value >> 3) != 0x2)
- fprintf(stderr, "%s: bad SDRAM idle mode %i\n",
+ fprintf(stderr, "%s: bad SDRAM idle mode %u\n",
__func__, (unsigned)value >> 3);
if (value & 2)
omap_sdrc_reset(s);
--
2.19.1
next prev parent reply other threads:[~2020-11-26 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 11:11 [PATCH 0/5] hw/misc: Fix some bad printf format specifiers Alex Chen
2020-11-26 11:11 ` [PATCH 1/5] i.MX25: Fix " Alex Chen
2020-11-26 11:11 ` [PATCH 2/5] i.MX31: " Alex Chen
2020-11-26 11:11 ` [PATCH 3/5] i.MX6: " Alex Chen
2020-11-26 11:11 ` [PATCH 4/5] i.MX6ul: " Alex Chen
2020-11-26 11:11 ` Alex Chen [this message]
2020-11-30 13:40 ` [PATCH 0/5] hw/misc: Fix some " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126111109.112238-6-alex.chen@huawei.com \
--to=alex.chen@huawei.com \
--cc=jcd@tribudubois.net \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).