From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F83C63697 for ; Thu, 26 Nov 2020 12:08:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6BC62087C for ; Thu, 26 Nov 2020 12:08:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c70VTbYw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6BC62087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiG4Y-00026h-9H for qemu-devel@archiver.kernel.org; Thu, 26 Nov 2020 07:08:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiG2s-0001Dg-6S for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:06:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiG2p-0001wQ-BL for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:06:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606392398; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mN/n+CnSMcOkY4R5sv8giQPuR7sjSZtBfPz4DC6XvHM=; b=c70VTbYwTF8iplOjD1kNVYziJJeK8+FLxhXv6dWSuMgZ5BULdE1gUqFyfmpycu766MiUfC kP65E/UPBp/l+S27LFfOOdYbcB4kIeQ1oDiejkafI4zt6uXBp6On0WWEuvg1cBV7AQYi1n JjK8h0d6NVJwPYm236A33rQn6+ghBDw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-juHihixdOoeHSnuY7nsBzg-1; Thu, 26 Nov 2020 07:06:33 -0500 X-MC-Unique: juHihixdOoeHSnuY7nsBzg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A756E835B48; Thu, 26 Nov 2020 12:06:31 +0000 (UTC) Received: from redhat.com (ovpn-115-34.ams2.redhat.com [10.36.115.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AE1260C05; Thu, 26 Nov 2020 12:06:27 +0000 (UTC) Date: Thu, 26 Nov 2020 12:06:24 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Subject: Re: [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler Message-ID: <20201126120624.GE1122957@redhat.com> References: <20201126112915.525285-1-marcandre.lureau@redhat.com> <20201126112915.525285-3-marcandre.lureau@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 26, 2020 at 11:49:28AM +0000, Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:29, wrote: > > > > From: Philippe Mathieu-Daudé > > > > Since commit efc6c070aca ("configure: Add a test for the > > minimum compiler version") the minimum compiler version > > required for GCC is 4.8, which has the GCC BZ#36793 bug fixed. > > > > We can safely remove the special case introduced in commit > > a281ebc11a6 ("virtio: add missing mb() on notification"). > > > > With clang 3.8 (xenial amd64) __ATOMIC_RELAXED is defined, so the chunk > > to remove (which is x86-specific), isn't reached. > > The minimum clang version enforced by configure is 3.4, not 3.8. > (Or Apple XCode clang 5.1 -- they use a different versioning scheme!) We picked clang 3.4 based on fact that is what ships in EPEL7, and Debian Jessie 3.5. We then picked the XCode version to match. Based on our platform support matrix we no longer support Debian Jessie, and IMHO we also don't really need to consider 3rd party add-on repos shipping non-default toolschains. So IMHO we could entirely ignore clang in EPEL7 when picking min versions. IOW, we are likely justified in picking a new clang version if someone wants to research what is a suitable min version across our intended supported distros. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|