From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0565BC63697 for ; Thu, 26 Nov 2020 12:06:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 271772087C for ; Thu, 26 Nov 2020 12:06:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gxO7L1wv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 271772087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiG33-0001Ag-Qh for qemu-devel@archiver.kernel.org; Thu, 26 Nov 2020 07:06:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiG1l-0000Io-RF for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:05:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiG1i-0001Ye-Tc for qemu-devel@nongnu.org; Thu, 26 Nov 2020 07:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606392329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AtkHF0CSyVzoa7MZjB2FgYtGuAwv3xf9QWhtuJfhkS0=; b=gxO7L1wvGS+C8b+8mDn66h1yyAGlZAFgQy2kZSSJQOIEo8PageJXIZ2AitrnEpYsGXUhJX sh8aAiORyt4c2SvYLa2y+QIlc4+6N96xWdQMVvaMndnDkQbRgu9ZA0OR2d1WzxMrYV9jjl 7H66CeoG39LW/Ppyfg2avs4zzDxYaxg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-Bnn2gfj4MPmwPVE1EMPitg-1; Thu, 26 Nov 2020 07:05:27 -0500 X-MC-Unique: Bnn2gfj4MPmwPVE1EMPitg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4479F81CBE1; Thu, 26 Nov 2020 12:05:26 +0000 (UTC) Received: from gondolin (ovpn-113-125.ams2.redhat.com [10.36.113.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id 076D25D9C6; Thu, 26 Nov 2020 12:05:21 +0000 (UTC) Date: Thu, 26 Nov 2020 13:05:19 +0100 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x Message-ID: <20201126130519.4e178309.cohuck@redhat.com> In-Reply-To: <20201125163034.5a935baa.cohuck@redhat.com> References: <20201125135820.1442611-1-cohuck@redhat.com> <148a7ef1-aae2-89ae-88f7-3c70c9f02999@redhat.com> <20201125163034.5a935baa.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 25 Nov 2020 16:30:34 +0100 Cornelia Huck wrote: > On Wed, 25 Nov 2020 16:03:13 +0100 > Thomas Huth wrote: > > > On 25/11/2020 14.58, Cornelia Huck wrote: > > > + def test(self): > > > + > > > + """ > > > + :avocado: tags=arch:s390x > > > + :avocado: tags=machine:s390-ccw-virtio > > > + """ > > > + > > > + # XXX: switch to https when debian fixes their certificate > > > + kernel_url = ('http://archive.debian.org/debian/dists/jessie/main' > > > + '/installer-s390x/current/images/generic/kernel.debian') > > > + kernel_hash = '5af1aa839754f4d8817fb5878b4d55dfc887f45d' > > > + kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash) > > > + > > > + initrd_url = ('http://archive.debian.org/debian/dists/jessie/main' > > > + '/installer-s390x/current/images/generic/initrd.debian') > > > + initrd_hash = '99252b28306184b876f979585e2d4bfe96b27464' > > > + initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash) > > > + > > > + self.vm.set_console() > > > + kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > > > + 'console=sclp0 root=/dev/ram0 BOOT_DEBUG=3') > > > + self.vm.add_args('-nographic', > > > + '-kernel', kernel_path, > > > + '-initrd', initrd_path, > > > + '-append', kernel_command_line, > > > + '-device', 'virtio-net-ccw,devno=fe.1.1111', > > > + '-device', 'virtio-net-pci') > > > > Maybe use '-device', 'virtio-net-pci,addr=6' or something similar to check a > > non-default PCI address, too? > > Not sure if addr= will do the trick, I may need to add a zpci device. It seems I need both a zpci device (to specify the uid) and a newer kernel (so that the uid is actually used to construct the address in the guest). I guess I should use snapshots.debian.org to get a stable link to a newer version?