From: Igor Mammedov <imammedo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 14/36] vl: extract default devices to separate functions
Date: Thu, 26 Nov 2020 18:29:40 +0100 [thread overview]
Message-ID: <20201126182940.664004a9@redhat.com> (raw)
In-Reply-To: <20201123141435.2726558-15-pbonzini@redhat.com>
On Mon, 23 Nov 2020 09:14:13 -0500
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> softmmu/vl.c | 216 +++++++++++++++++++++++++++------------------------
> 1 file changed, 114 insertions(+), 102 deletions(-)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 5d68cf828c..b6c62e1e4f 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -125,7 +125,9 @@ static const char *boot_order;
> static const char *boot_once;
> static const char *incoming;
> static const char *loadvm;
> +static int display_remote;
> static QemuPluginList plugin_list = QTAILQ_HEAD_INITIALIZER(plugin_list);
> +static bool nographic = false;
> enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;
> static int mem_prealloc; /* force preallocation of physical target memory */
> int display_opengl;
> @@ -147,6 +149,7 @@ static int rtc_host_datetime_offset = -1; /* valid & used only with
> RTC_BASE_DATETIME */
> QEMUClockType rtc_clock;
> int vga_interface_type = VGA_NONE;
> +static const char *vga_model = NULL;
> static DisplayOptions dpy;
> static int num_serial_hds;
> static Chardev **serial_hds;
> @@ -2224,6 +2227,115 @@ static int foreach_device_config(int type, int (*func)(const char *cmdline))
> return 0;
> }
>
> +static void qemu_disable_default_devices(void)
> +{
> + MachineClass *machine_class = MACHINE_GET_CLASS(current_machine);
> +
> + qemu_opts_foreach(qemu_find_opts("device"),
> + default_driver_check, NULL, NULL);
> + qemu_opts_foreach(qemu_find_opts("global"),
> + default_driver_check, NULL, NULL);
> +
> + if (!vga_model && !default_vga) {
> + vga_interface_type = VGA_DEVICE;
> + }
> + if (!has_defaults || machine_class->no_serial) {
> + default_serial = 0;
> + }
> + if (!has_defaults || machine_class->no_parallel) {
> + default_parallel = 0;
> + }
> + if (!has_defaults || machine_class->no_floppy) {
> + default_floppy = 0;
> + }
> + if (!has_defaults || machine_class->no_cdrom) {
> + default_cdrom = 0;
> + }
> + if (!has_defaults || machine_class->no_sdcard) {
> + default_sdcard = 0;
> + }
> + if (!has_defaults) {
> + default_monitor = 0;
> + default_net = 0;
> + default_vga = 0;
> + }
> +}
> +
> +static void qemu_create_default_devices(void)
> +{
> + MachineClass *machine_class = MACHINE_GET_CLASS(current_machine);
> +
> + if (is_daemonized()) {
> + /* According to documentation and historically, -nographic redirects
> + * serial port, parallel port and monitor to stdio, which does not work
> + * with -daemonize. We can redirect these to null instead, but since
> + * -nographic is legacy, let's just error out.
> + * We disallow -nographic only if all other ports are not redirected
> + * explicitly, to not break existing legacy setups which uses
> + * -nographic _and_ redirects all ports explicitly - this is valid
> + * usage, -nographic is just a no-op in this case.
> + */
> + if (nographic
> + && (default_parallel || default_serial || default_monitor)) {
> + error_report("-nographic cannot be used with -daemonize");
> + exit(1);
> + }
> + }
> +
> + if (nographic) {
> + if (default_parallel)
> + add_device_config(DEV_PARALLEL, "null");
> + if (default_serial && default_monitor) {
> + add_device_config(DEV_SERIAL, "mon:stdio");
> + } else {
> + if (default_serial)
> + add_device_config(DEV_SERIAL, "stdio");
> + if (default_monitor)
> + monitor_parse("stdio", "readline", false);
> + }
> + } else {
> + if (default_serial)
> + add_device_config(DEV_SERIAL, "vc:80Cx24C");
> + if (default_parallel)
> + add_device_config(DEV_PARALLEL, "vc:80Cx24C");
> + if (default_monitor)
> + monitor_parse("vc:80Cx24C", "readline", false);
> + }
> +
> + if (default_net) {
> + QemuOptsList *net = qemu_find_opts("net");
> + qemu_opts_parse(net, "nic", true, &error_abort);
> +#ifdef CONFIG_SLIRP
> + qemu_opts_parse(net, "user", true, &error_abort);
> +#endif
> + }
> +
> +#if defined(CONFIG_VNC)
> + if (!QTAILQ_EMPTY(&(qemu_find_opts("vnc")->head))) {
> + display_remote++;
> + }
> +#endif
> + if (dpy.type == DISPLAY_TYPE_DEFAULT && !display_remote) {
> + if (!qemu_display_find_default(&dpy)) {
> + dpy.type = DISPLAY_TYPE_NONE;
> +#if defined(CONFIG_VNC)
> + vnc_parse("localhost:0,to=99,id=default", &error_abort);
> +#endif
> + }
> + }
> + if (dpy.type == DISPLAY_TYPE_DEFAULT) {
> + dpy.type = DISPLAY_TYPE_NONE;
> + }
> +
> + /* If no default VGA is requested, the default is "none". */
> + if (default_vga) {
> + vga_model = get_default_vga_model(machine_class);
> + }
> + if (vga_model) {
> + select_vgahw(machine_class, vga_model);
> + }
> +}
> +
> static int serial_parse(const char *devname)
> {
> int index = num_serial_hds;
> @@ -3209,10 +3321,7 @@ void qemu_init(int argc, char **argv, char **envp)
> int optind;
> const char *optarg;
> MachineClass *machine_class;
> - const char *vga_model = NULL;
> bool userconfig = true;
> - bool nographic = false;
> - int display_remote = 0;
> ram_addr_t maxram_size;
> uint64_t ram_slots = 0;
> FILE *vmstate_dump_file = NULL;
> @@ -4188,97 +4297,8 @@ void qemu_init(int argc, char **argv, char **envp)
> machine_class->default_machine_opts, 0);
> }
>
> - qemu_opts_foreach(qemu_find_opts("device"),
> - default_driver_check, NULL, NULL);
> - qemu_opts_foreach(qemu_find_opts("global"),
> - default_driver_check, NULL, NULL);
> -
> - if (!vga_model && !default_vga) {
> - vga_interface_type = VGA_DEVICE;
> - }
> - if (!has_defaults || machine_class->no_serial) {
> - default_serial = 0;
> - }
> - if (!has_defaults || machine_class->no_parallel) {
> - default_parallel = 0;
> - }
> - if (!has_defaults || machine_class->no_floppy) {
> - default_floppy = 0;
> - }
> - if (!has_defaults || machine_class->no_cdrom) {
> - default_cdrom = 0;
> - }
> - if (!has_defaults || machine_class->no_sdcard) {
> - default_sdcard = 0;
> - }
> - if (!has_defaults) {
> - default_monitor = 0;
> - default_net = 0;
> - default_vga = 0;
> - }
> -
> - if (is_daemonized()) {
> - /* According to documentation and historically, -nographic redirects
> - * serial port, parallel port and monitor to stdio, which does not work
> - * with -daemonize. We can redirect these to null instead, but since
> - * -nographic is legacy, let's just error out.
> - * We disallow -nographic only if all other ports are not redirected
> - * explicitly, to not break existing legacy setups which uses
> - * -nographic _and_ redirects all ports explicitly - this is valid
> - * usage, -nographic is just a no-op in this case.
> - */
> - if (nographic
> - && (default_parallel || default_serial || default_monitor)) {
> - error_report("-nographic cannot be used with -daemonize");
> - exit(1);
> - }
> - }
> -
> - if (nographic) {
> - if (default_parallel)
> - add_device_config(DEV_PARALLEL, "null");
> - if (default_serial && default_monitor) {
> - add_device_config(DEV_SERIAL, "mon:stdio");
> - } else {
> - if (default_serial)
> - add_device_config(DEV_SERIAL, "stdio");
> - if (default_monitor)
> - monitor_parse("stdio", "readline", false);
> - }
> - } else {
> - if (default_serial)
> - add_device_config(DEV_SERIAL, "vc:80Cx24C");
> - if (default_parallel)
> - add_device_config(DEV_PARALLEL, "vc:80Cx24C");
> - if (default_monitor)
> - monitor_parse("vc:80Cx24C", "readline", false);
> - }
> -
> - if (default_net) {
> - QemuOptsList *net = qemu_find_opts("net");
> - qemu_opts_parse(net, "nic", true, &error_abort);
> -#ifdef CONFIG_SLIRP
> - qemu_opts_parse(net, "user", true, &error_abort);
> -#endif
> - }
> -
> -#if defined(CONFIG_VNC)
> - if (!QTAILQ_EMPTY(&(qemu_find_opts("vnc")->head))) {
> - display_remote++;
> - }
> -#endif
> - if (dpy.type == DISPLAY_TYPE_DEFAULT && !display_remote) {
> - if (!qemu_display_find_default(&dpy)) {
> - dpy.type = DISPLAY_TYPE_NONE;
> -#if defined(CONFIG_VNC)
> - vnc_parse("localhost:0,to=99,id=default", &error_abort);
> -#endif
> - }
> - }
> - if (dpy.type == DISPLAY_TYPE_DEFAULT) {
> - dpy.type = DISPLAY_TYPE_NONE;
> - }
> -
> + qemu_disable_default_devices();
> + qemu_create_default_devices();
> if ((alt_grab || ctrl_grab) && dpy.type != DISPLAY_TYPE_SDL) {
> error_report("-alt-grab and -ctrl-grab are only valid "
> "for SDL, ignoring option");
> @@ -4417,14 +4437,6 @@ void qemu_init(int argc, char **argv, char **envp)
> qemu_semihosting_connect_chardevs();
> qemu_semihosting_console_init();
>
> - /* If no default VGA is requested, the default is "none". */
> - if (default_vga) {
> - vga_model = get_default_vga_model(machine_class);
> - }
> - if (vga_model) {
> - select_vgahw(machine_class, vga_model);
> - }
> -
> /* This checkpoint is required by replay to separate prior clock
> reading from the other reads, because timer polling functions query
> clock values from the log. */
next prev parent reply other threads:[~2020-11-26 17:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 14:13 [PATCH v3 00/36] cleanup qemu_init and make sense of command line processing Paolo Bonzini
2020-11-23 14:14 ` [PATCH 01/36] vl: extract validation of -smp to machine.c Paolo Bonzini
2020-11-23 14:14 ` [PATCH 02/36] vl: remove bogus check Paolo Bonzini
2020-11-23 14:14 ` [PATCH 03/36] vl: split various early command line options to a separate function Paolo Bonzini
2020-11-26 16:47 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 04/36] vl: move various initialization routines out of qemu_init Paolo Bonzini
2020-11-23 14:14 ` [PATCH 05/36] vl: extract qemu_init_subsystems Paolo Bonzini
2020-11-23 14:14 ` [PATCH 06/36] vl: move prelaunch part of qemu_init to new functions Paolo Bonzini
2020-11-23 14:14 ` [PATCH 07/36] vl: extract various command line validation snippets to a new function Paolo Bonzini
2020-11-23 14:14 ` [PATCH 08/36] vl: preconfig and loadvm are mutually exclusive Paolo Bonzini
2020-11-23 14:14 ` [PATCH 09/36] vl: extract various command line desugaring snippets to a new function Paolo Bonzini
2020-11-23 14:14 ` [PATCH 10/36] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts Paolo Bonzini
2020-11-23 14:14 ` [PATCH 11/36] vl: create "-net nic -net user" default earlier Paolo Bonzini
2020-11-23 14:14 ` [PATCH 12/36] vl: load plugins as late as possible Paolo Bonzini
2020-11-26 16:54 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board Paolo Bonzini
2020-11-26 17:10 ` Igor Mammedov
2020-11-27 5:03 ` Paolo Bonzini
2020-11-27 10:31 ` Igor Mammedov
2020-11-27 11:22 ` Paolo Bonzini
2020-11-27 12:12 ` Igor Mammedov
2020-11-27 12:22 ` Paolo Bonzini
2020-11-23 14:14 ` [PATCH 14/36] vl: extract default devices to separate functions Paolo Bonzini
2020-11-26 17:29 ` Igor Mammedov [this message]
2020-11-23 14:14 ` [PATCH 15/36] vl: move CHECKPOINT_INIT after preconfig Paolo Bonzini
2020-11-26 17:36 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 16/36] vl: separate qemu_create_early_backends Paolo Bonzini
2020-11-23 14:14 ` [PATCH 17/36] vl: separate qemu_create_late_backends Paolo Bonzini
2020-11-23 14:14 ` [PATCH 18/36] vl: separate qemu_create_machine Paolo Bonzini
2020-11-23 14:14 ` [PATCH 19/36] vl: separate qemu_apply_machine_options Paolo Bonzini
2020-11-23 14:14 ` [PATCH 20/36] vl: separate qemu_resolve_machine_memdev Paolo Bonzini
2020-11-26 17:39 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 21/36] vl: initialize displays before preconfig loop Paolo Bonzini
2020-11-26 17:51 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 22/36] vl: move -global check earlier Paolo Bonzini
2020-11-26 17:55 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 23/36] migration, vl: start migration via qmp_migrate_incoming Paolo Bonzini
2020-11-26 18:04 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 24/36] vl: start VM via qmp_cont Paolo Bonzini
2020-11-23 14:14 ` [PATCH 25/36] hmp: introduce cmd_available Paolo Bonzini
2020-11-23 14:14 ` [PATCH 26/36] remove preconfig state Paolo Bonzini
2020-11-26 18:55 ` Igor Mammedov
2020-11-27 5:19 ` Paolo Bonzini
2020-11-27 10:50 ` Igor Mammedov
2020-11-27 11:50 ` Paolo Bonzini
2020-11-30 12:41 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 27/36] vl: remove separate preconfig main_loop Paolo Bonzini
2020-11-30 12:46 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 28/36] vl: allow -incoming defer with -preconfig Paolo Bonzini
2020-11-27 10:51 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 29/36] vl: extract softmmu/datadir.c Paolo Bonzini
2020-11-27 12:06 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 30/36] vl: extract machine done notifiers Paolo Bonzini
2020-11-27 12:14 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 31/36] vl: extract softmmu/rtc.c Paolo Bonzini
2020-11-27 12:43 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 32/36] vl: extract softmmu/runstate.c Paolo Bonzini
2020-11-27 12:59 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 33/36] vl: extract softmmu/globals.c Paolo Bonzini
2020-11-27 13:19 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 34/36] vl: remove serial_max_hds Paolo Bonzini
2020-11-27 13:11 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 35/36] vl: clean up -boot variables Paolo Bonzini
2020-11-27 13:12 ` Igor Mammedov
2020-11-23 14:14 ` [PATCH 36/36] vl: move all generic initialization out of vl.c Paolo Bonzini
2020-11-27 13:30 ` Igor Mammedov
2020-11-27 12:00 ` [PATCH 37/36] machine: introduce MachineInitPhase Paolo Bonzini
2020-11-27 13:29 ` Igor Mammedov
2020-11-27 15:29 ` Paolo Bonzini
2020-11-30 12:50 ` [PATCH v3 00/36] cleanup qemu_init and make sense of command line processing Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126182940.664004a9@redhat.com \
--to=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).