qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PULL 0/1] Fixes 20201127 patches
@ 2020-11-27  7:07 Gerd Hoffmann
  2020-11-27  7:07 ` [PULL 1/1] qxl: fix segfault Gerd Hoffmann
  2020-11-27 12:45 ` [PULL 0/1] Fixes 20201127 patches Peter Maydell
  0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2020-11-27  7:07 UTC (permalink / raw)
  To: qemu-devel; +Cc: Gerd Hoffmann

The following changes since commit dd3d2340c4076d1735cd0f7cb61f4d8622b9562d:

  Update version for v5.2.0-rc3 release (2020-11-24 22:13:30 +0000)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/fixes-20201127-pull-request

for you to fetch changes up to 6fc5183a65b59d43441296cd2f72f8e55dc5dd04:

  qxl: fix segfault (2020-11-25 12:33:21 +0100)

----------------------------------------------------------------
qxl: fix segfault

----------------------------------------------------------------

Gerd Hoffmann (1):
  qxl: fix segfault

 ui/console.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.27.0




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] qxl: fix segfault
  2020-11-27  7:07 [PULL 0/1] Fixes 20201127 patches Gerd Hoffmann
@ 2020-11-27  7:07 ` Gerd Hoffmann
  2020-11-27 12:45 ` [PULL 0/1] Fixes 20201127 patches Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2020-11-27  7:07 UTC (permalink / raw)
  To: qemu-devel; +Cc: Marc-André Lureau, Gerd Hoffmann

Add missing sanity check.
Reproducer: run qemu with "-device qxl" but without "-spice ..."

Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine")
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20201124122936.30588-1-kraxel@redhat.com
---
 ui/console.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui/console.c b/ui/console.c
index e07d2c380df7..53dee8e26b17 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -264,7 +264,9 @@ static void gui_setup_refresh(DisplayState *ds)
 
 void graphic_hw_update_done(QemuConsole *con)
 {
-    qemu_co_queue_restart_all(&con->dump_queue);
+    if (con) {
+        qemu_co_queue_restart_all(&con->dump_queue);
+    }
 }
 
 void graphic_hw_update(QemuConsole *con)
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] Fixes 20201127 patches
  2020-11-27  7:07 [PULL 0/1] Fixes 20201127 patches Gerd Hoffmann
  2020-11-27  7:07 ` [PULL 1/1] qxl: fix segfault Gerd Hoffmann
@ 2020-11-27 12:45 ` Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-11-27 12:45 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: QEMU Developers

On Fri, 27 Nov 2020 at 07:08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit dd3d2340c4076d1735cd0f7cb61f4d8622b9562d:
>
>   Update version for v5.2.0-rc3 release (2020-11-24 22:13:30 +0000)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/fixes-20201127-pull-request
>
> for you to fetch changes up to 6fc5183a65b59d43441296cd2f72f8e55dc5dd04:
>
>   qxl: fix segfault (2020-11-25 12:33:21 +0100)
>
> ----------------------------------------------------------------
> qxl: fix segfault
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-27 12:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27  7:07 [PULL 0/1] Fixes 20201127 patches Gerd Hoffmann
2020-11-27  7:07 ` [PULL 1/1] qxl: fix segfault Gerd Hoffmann
2020-11-27 12:45 ` [PULL 0/1] Fixes 20201127 patches Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).