From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13860C2D0E4 for ; Fri, 27 Nov 2020 09:47:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59CF5221F7 for ; Fri, 27 Nov 2020 09:47:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EeDCKejP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59CF5221F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiaLs-0004mO-BW for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 04:47:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiaGG-00028B-Od for qemu-devel@nongnu.org; Fri, 27 Nov 2020 04:41:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiaGF-0001uB-Af for qemu-devel@nongnu.org; Fri, 27 Nov 2020 04:41:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606470110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYHT/ap7/LY7W4fH9OJaLGJCx9Xw8hIJmnaoRbpdI38=; b=EeDCKejPOLhvzzyBRjcbjfWnrCOZYvszKl5jJ6vzgSmOAgOzYUZfxnfMG9/c5ANNd5tOJq wq2/SrB6FeB7UNtQuq+p2t/HdGrCPobxJ38zprFs/5qHGa6U3rTdiAUk5DCcxJTSm9NRg3 c54fVOw2hh7hZwn5tbhzRA/Qw+qOQgs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-VxUbUth_OEWaR5Sl19aeJg-1; Fri, 27 Nov 2020 04:41:44 -0500 X-MC-Unique: VxUbUth_OEWaR5Sl19aeJg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BDBD5803F4E; Fri, 27 Nov 2020 09:41:42 +0000 (UTC) Received: from gondolin (ovpn-113-65.ams2.redhat.com [10.36.113.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id A502B60636; Fri, 27 Nov 2020 09:41:41 +0000 (UTC) Date: Fri, 27 Nov 2020 10:41:38 +0100 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH v2] qga/commands-posix: Send CCW address on s390x with the fsinfo data Message-ID: <20201127104138.36af6681.cohuck@redhat.com> In-Reply-To: <20201127082353.448251-1-thuth@redhat.com> References: <20201127082353.448251-1-thuth@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 27 Nov 2020 09:23:53 +0100 Thomas Huth wrote: > We need the CCW address on the libvirt side to correctly identify > the disk, so add this information to the GuestDiskAddress on s390x. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075 > Signed-off-by: Thomas Huth > --- > v2: Add missing comment about "subchno" (thanks to Cornelia for spotting this) > > The libirt part of this fix can be found here: > https://www.redhat.com/archives/libvir-list/2020-November/msg01455.html > > qga/commands-posix.c | 34 ++++++++++++++++++++++++++++++++++ > qga/qapi-schema.json | 20 +++++++++++++++++++- > 2 files changed, 53 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck